yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-23 00:28:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(ingest): throw codegen error on duplicate class names (#9960)

Browse Source
This commit is contained in:
Harshal Sheth 2024-02-29 16:13:43 -08:00 committed by GitHub
parent 3284235850
commit 4c83f10cdb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
metadata-ingestion/scripts/avro_codegen.py
View File

@ -148,11 +148,27 @@ def merge_schemas(schemas_obj: List[dict]) -> str:
# Combine schemas as a "union" of all of the types. # Combine schemas as a "union" of all of the types.
merged = ["null"] + schemas_obj merged = ["null"] + schemas_obj
# Check that we don't have the same class name in multiple namespaces.
names_to_spaces: Dict[str, str] = {}
# Patch add_name method to NOT complain about duplicate names. # Patch add_name method to NOT complain about duplicate names.
class NamesWithDups(avro.schema.Names): class NamesWithDups(avro.schema.Names):
def add_name(self, name_attr, space_attr, new_schema): def add_name(self, name_attr, space_attr, new_schema):
to_add = avro.schema.Name(name_attr, space_attr, self.default_namespace) to_add = avro.schema.Name(name_attr, space_attr, self.default_namespace)
assert to_add.name
assert to_add.space
assert to_add.fullname assert to_add.fullname
if to_add.name in names_to_spaces:
if names_to_spaces[to_add.name] != to_add.space:
raise ValueError(
f"Duplicate name {to_add.name} in namespaces {names_to_spaces[to_add.name]} and {to_add.space}. "
"This will cause conflicts in the generated code."
)
else:
names_to_spaces[to_add.name] = to_add.space
self.names[to_add.fullname] = new_schema self.names[to_add.fullname] = new_schema
return to_add return to_add