DSS-6551 Adds user notification for confidential tab on update success

wherehows-web/app/components/dataset-confidential.js

@@ -6,6 +6,7 @@ const {
   isBlank,
   computed,
   getWithDefault,
+  setProperties,
   Component
 } = Ember;
 
@@ -18,6 +19,10 @@ const classifiers = [
   'mustBeEncrypted',
   'mustBeMasked'
 ];
+
+// TODO: DSS-6671 Extract to constants module
+const successUpdating = 'Your changes have been successfully saved!';
+const failedUpdating = 'Oops! We are having trouble updating this dataset at the moment.';
 /**
  * Takes a string, returns a formatted string. Niche , single use case
  * for now, so no need to make into a helper
@@ -50,16 +55,17 @@ export default Component.extend({
     //   Also, the expectation is that the association from fieldName -> classification
     //   is one-to-one hence no check to ensure a fieldName gets clobbered
     //   in the lookup assignment
-    return Object.keys(sourceClasses).reduce((lookup, classificationKey) =>
+    return Object.keys(sourceClasses)
-        // For the provided classificationKey, iterate over it's fieldNames,
+      .reduce((lookup, classificationKey) =>
-        //   and assign the classificationKey to the fieldName in the table
+          // For the provided classificationKey, iterate over it's fieldNames,
-        (sourceClasses[classificationKey] || []).reduce((lookup, fieldName) => {
+          //   and assign the classificationKey to the fieldName in the table
-          // cKey -> 1...fieldNameList => fieldName -> cKey
+          (sourceClasses[classificationKey] || []).reduce((lookup, fieldName) => {
-          lookup[fieldName] = classificationKey;
+            // cKey -> 1...fieldNameList => fieldName -> cKey
-          return lookup;
+            lookup[fieldName] = classificationKey;
-        }, lookup),
+            return lookup;
-      {}
+          }, lookup),
-    );
+        {}
+      );
   }),
 
   /**
@@ -84,6 +90,32 @@ export default Component.extend({
     }
   ),
 
+  /**
+   * TODO: DSS-6672 Extract to notifications service
+   * Helper method to update user when an async server update to the
+   * security specification is handled.
+   * @param {XMLHttpRequest|Promise|jqXHR|*} request the server request
+   */
+  whenRequestCompletes(request) {
+    Promise.resolve(request)
+      .then(({return_code}) => {
+        // The server api currently responds with an object containing
+        //   a return_code when complete
+        return return_code === 200 ?
+          setProperties(this, {
+            message: successUpdating,
+            alertType: 'success'
+          }) :
+          Promise.reject(`Reason code for this is ${return_code}`);
+      })
+      .catch((err = '') => {
+        setProperties(this, {
+          message: `${failedUpdating} \n ${err}`,
+          alertType: 'danger'
+        });
+      });
+  },
+
   actions: {
     /**
      * Toggles the provided identifierField onto a classification list
@@ -101,7 +133,8 @@ export default Component.extend({
       if (!isBlank(currentClass)) {
         // Get the current classification list
         const currentClassification = get(
-          this, `${sourceClassificationKey}.${currentClass}`
+          this,
+          `${sourceClassificationKey}.${currentClass}`
         );
         // Remove identifierField from list
         currentClassification.removeObject(identifierField);
@@ -109,7 +142,10 @@ export default Component.extend({
 
       if (classKey) {
         // Get the candidate list
-        let classification = get(this, `${sourceClassificationKey}.${classKey}`);
+        let classification = get(
+          this,
+          `${sourceClassificationKey}.${classKey}`
+        );
         // In the case that the list is not pre-populated,
         //  the value will be the default null, array ops won't work here
         //  ...so make array
@@ -122,16 +158,22 @@ export default Component.extend({
       }
     },
 
-    // Notify controller to propagate changes
+    /**
+     * Notify controller to propagate changes
+     * @return {Boolean}
+     */
     saveSecuritySpecification() {
-      get(this, 'onSave')();
+      this.whenRequestCompletes(get(this, 'onSave')());
+
       return false;
     },
 
-    // Rolls back changes made to the compliance spec to current
+    /**
-    // server state
+     * Rolls back changes made to the compliance spec to current
+     * server state
+     */
     resetSecuritySpecification() {
-      get(this, 'onReset')();
+      this.whenRequestCompletes(get(this, 'onReset')());
     }
   }
 });

wherehows-web/app/controllers/datasets/dataset.js

@@ -305,7 +305,7 @@ export default Ember.Controller.extend({
      * then updates controller state if successful
      */
     saveSecuritySpecification() {
-      this.saveJson('security', this.get('securitySpecification'))
+      return this.saveJson('security', this.get('securitySpecification'))
           .then(this.actions.resetSecuritySpecification.bind(this))
           .catch(this.exceptionOnSave);
     },
@@ -315,9 +315,9 @@ export default Ember.Controller.extend({
      * then updates controller state if successful
      */
     savePrivacyCompliancePolicy() {
-      this.saveJson('compliance', this.get('privacyCompliancePolicy'))
+      return this.saveJson('compliance', this.get('privacyCompliancePolicy'))
           .then(this.actions.resetPrivacyCompliancePolicy.bind(this))
           .catch(this.exceptionOnSave);
     }
   }
-});
+});

wherehows-web/app/styles/components/dataset-compliance/_compliance-prompts.scss

@@ -2,7 +2,7 @@
  * Prompt for privacy compliance
  */
 .metadata-prompt {
-  margin-top: 40px;
+  margin-top: 30px;
 
   /**
    * Overrides default styles

wherehows-web/app/templates/components/dataset-confidential.hbs

@@ -13,6 +13,10 @@
     </button>
   </section>
 
+  <div class="alert alert-{{alertType}} post-action-notification" role="alert">
+    {{if message message ""}}
+  </div>
+
   <section class="metadata-prompt" id="has-confidentiality">
     <header class="metadata-prompt__header">
       <p>Which fields should be classified as Confidential or Highly Confidential (if any)?</p>

wherehows-web/app/templates/datasets/dataset.hbs

@@ -104,7 +104,7 @@
     </div>
   {{/if}}
 </div>
-<ul class="nav nav-tabs nav-justified">
+<ul class="nav nav-tabs nav-justified tabbed-navigation-list">
   {{#unless isPinot}}
     <li id="properties">
       <a data-toggle="tab" href="#propertiestab">