From 5de346b7adc858e76750bb1a0a5de36ac03ee1df Mon Sep 17 00:00:00 2001
From: Gabe Lyons <itsgabelyons@gmail.com>
Date: Thu, 13 May 2021 18:11:32 -0700
Subject: [PATCH] fix(search): have search bar ignore blank searches (#2556)

---
 datahub-web-react/src/app/home/HomePageHeader.tsx   | 3 +++
 datahub-web-react/src/app/search/SearchPage.tsx     | 3 +++
 datahub-web-react/src/app/search/SearchablePage.tsx | 3 +++
 3 files changed, 9 insertions(+)

diff --git a/datahub-web-react/src/app/home/HomePageHeader.tsx b/datahub-web-react/src/app/home/HomePageHeader.tsx
index f204fce63b..1b373d6773 100644
--- a/datahub-web-react/src/app/home/HomePageHeader.tsx
+++ b/datahub-web-react/src/app/home/HomePageHeader.tsx
@@ -115,6 +115,9 @@ export const HomePageHeader = () => {
     const isAnalyticsEnabled = data && data.isAnalyticsEnabled;
 
     const onSearch = (query: string) => {
+        if (query.trim().length === 0) {
+            return;
+        }
         analytics.event({
             type: EventType.SearchEvent,
             query,
diff --git a/datahub-web-react/src/app/search/SearchPage.tsx b/datahub-web-react/src/app/search/SearchPage.tsx
index f8d3ffcbe1..305748b569 100644
--- a/datahub-web-react/src/app/search/SearchPage.tsx
+++ b/datahub-web-react/src/app/search/SearchPage.tsx
@@ -55,6 +55,9 @@ export const SearchPage = () => {
     const filters: Array<FacetFilterInput> = useFilters(params);
 
     const onSearch = (q: string) => {
+        if (query.trim().length === 0) {
+            return;
+        }
         analytics.event({
             type: EventType.SearchEvent,
             query: q,
diff --git a/datahub-web-react/src/app/search/SearchablePage.tsx b/datahub-web-react/src/app/search/SearchablePage.tsx
index 4f55c74694..77975be2e2 100644
--- a/datahub-web-react/src/app/search/SearchablePage.tsx
+++ b/datahub-web-react/src/app/search/SearchablePage.tsx
@@ -38,6 +38,9 @@ export const SearchablePage = ({ initialQuery, onSearch, onAutoComplete, childre
     const [getAutoCompleteResults, { data: suggestionsData }] = useGetAutoCompleteResultsLazyQuery();
 
     const search = (query: string) => {
+        if (query.trim().length === 0) {
+            return;
+        }
         analytics.event({
             type: EventType.SearchEvent,
             query,