yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-18 14:16:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(search): have search bar ignore blank searches (#2556)

Browse Source
This commit is contained in:
Gabe Lyons 2021-05-13 18:11:32 -07:00 committed by GitHub
parent 66d79be4b1
commit 5de346b7ad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
datahub-web-react/src/app/home/HomePageHeader.tsx
View File

@ -115,6 +115,9 @@ export const HomePageHeader = () => {
const isAnalyticsEnabled = data && data.isAnalyticsEnabled; const isAnalyticsEnabled = data && data.isAnalyticsEnabled;
const onSearch = (query: string) => { const onSearch = (query: string) => {
if (query.trim().length === 0) {
return;
}
analytics.event({ analytics.event({
type: EventType.SearchEvent, type: EventType.SearchEvent,
query, query,

3
datahub-web-react/src/app/search/SearchPage.tsx
View File

@ -55,6 +55,9 @@ export const SearchPage = () => {
const filters: Array<FacetFilterInput> = useFilters(params); const filters: Array<FacetFilterInput> = useFilters(params);
const onSearch = (q: string) => { const onSearch = (q: string) => {
if (query.trim().length === 0) {
return;
}
analytics.event({ analytics.event({
type: EventType.SearchEvent, type: EventType.SearchEvent,
query: q, query: q,

3
datahub-web-react/src/app/search/SearchablePage.tsx
View File

@ -38,6 +38,9 @@ export const SearchablePage = ({ initialQuery, onSearch, onAutoComplete, childre
const [getAutoCompleteResults, { data: suggestionsData }] = useGetAutoCompleteResultsLazyQuery(); const [getAutoCompleteResults, { data: suggestionsData }] = useGetAutoCompleteResultsLazyQuery();
const search = (query: string) => { const search = (query: string) => {
if (query.trim().length === 0) {
return;
}
analytics.event({ analytics.event({
type: EventType.SearchEvent, type: EventType.SearchEvent,
query, query,