yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2026-01-08 07:46:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(policy): Add view entity page priv to all entity types (#4569)

Browse Source 
* Add to all

* Fix UI issues
This commit is contained in:
Dexter Lee 2022-04-04 12:05:04 -07:00 committed by GitHub
parent 1478489c9c
commit 5e0409f8a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
datahub-web-react/src/app/policy/PolicyPrivilegeForm.tsx
View File

@ -269,6 +269,12 @@ export default function PolicyPrivilegeForm({
);
};
const displayStringWithMaxLength = (displayStr, length) => {
return displayStr.length > length
? `${displayStr.substring(0, Math.min(length, displayStr.length))}...`
: displayStr;
};
return (
<PrivilegesForm layout="vertical">
{showResourceFilterInput && (
@ -280,7 +286,6 @@ export default function PolicyPrivilegeForm({
<Select
value={resourceTypeSelectValue}
mode="multiple"
filterOption={false}
placeholder="Apply to ALL resource types by default. Select types to apply to specific types of entities."
onSelect={onSelectResourceType}
onDeselect={onDeselectResourceType}
@ -319,7 +324,11 @@ export default function PolicyPrivilegeForm({
tagRender={(tagProps) => (
<Tag closable={tagProps.closable} onClose={tagProps.onClose}>
<Tooltip title={tagProps.value.toString()}>
{resourceUrnToDisplayName[tagProps.value.toString()] || tagProps.value.toString()}
{displayStringWithMaxLength(
resourceUrnToDisplayName[tagProps.value.toString()] ||
tagProps.value.toString(),
75,
)}
</Tooltip>
</Tag>
)}
@ -346,7 +355,10 @@ export default function PolicyPrivilegeForm({
onSearch={handleDomainSearch}
tagRender={(tagProps) => (
<Tag closable={tagProps.closable} onClose={tagProps.onClose}>
{domainUrnToDisplayName[tagProps.value.toString()] || tagProps.value.toString()}
{displayStringWithMaxLength(
domainUrnToDisplayName[tagProps.value.toString()] || tagProps.value.toString(),
75,
)}
</Tag>
)}
>

9
metadata-utils/src/main/java/com/linkedin/metadata/authorization/PoliciesConfig.java
View File

@ -252,7 +252,8 @@ public class PoliciesConfig {
"tag",
"Tags",
"Tags indexed by DataHub",
ImmutableList.of(EDIT_ENTITY_OWNERS_PRIVILEGE, EDIT_TAG_COLOR_PRIVILEGE, EDIT_ENTITY_DOCS_PRIVILEGE, EDIT_ENTITY_PRIVILEGE)
ImmutableList.of(VIEW_ENTITY_PAGE_PRIVILEGE, EDIT_ENTITY_OWNERS_PRIVILEGE, EDIT_TAG_COLOR_PRIVILEGE,
EDIT_ENTITY_DOCS_PRIVILEGE, EDIT_ENTITY_PRIVILEGE)
);
// Container Privileges
@ -268,7 +269,8 @@ public class PoliciesConfig {
"domain",
"Domains",
"Domains created on DataHub",
ImmutableList.of(EDIT_ENTITY_OWNERS_PRIVILEGE, EDIT_ENTITY_DOCS_PRIVILEGE, EDIT_ENTITY_DOC_LINKS_PRIVILEGE, EDIT_ENTITY_PRIVILEGE)
ImmutableList.of(VIEW_ENTITY_PAGE_PRIVILEGE, EDIT_ENTITY_OWNERS_PRIVILEGE, EDIT_ENTITY_DOCS_PRIVILEGE,
EDIT_ENTITY_DOC_LINKS_PRIVILEGE, EDIT_ENTITY_PRIVILEGE)
);
// Glossary Term Privileges
@ -277,6 +279,7 @@ public class PoliciesConfig {
"Glossary Terms",
"Glossary Terms created on DataHub",
ImmutableList.of(
VIEW_ENTITY_PAGE_PRIVILEGE,
EDIT_ENTITY_OWNERS_PRIVILEGE,
EDIT_ENTITY_DOCS_PRIVILEGE,
EDIT_ENTITY_DOC_LINKS_PRIVILEGE,
@ -290,6 +293,7 @@ public class PoliciesConfig {
"Groups",
"Groups on DataHub",
ImmutableList.of(
VIEW_ENTITY_PAGE_PRIVILEGE,
EDIT_ENTITY_OWNERS_PRIVILEGE,
EDIT_GROUP_MEMBERS_PRIVILEGE,
EDIT_CONTACT_INFO_PRIVILEGE,
@ -303,6 +307,7 @@ public class PoliciesConfig {
"Users",
"Users on DataHub",
ImmutableList.of(
VIEW_ENTITY_PAGE_PRIVILEGE,
EDIT_CONTACT_INFO_PRIVILEGE,
EDIT_USER_PROFILE_PRIVILEGE,
EDIT_ENTITY_PRIVILEGE)