yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-29 19:07:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest/looker): do not instantiate LookerDashboardSource on test_connection (#7369)

Browse Source
This commit is contained in:
Andrew Sikowitz 2023-02-18 03:32:28 -05:00 committed by GitHub
parent ad742f14c8
commit 632f730803
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
metadata-ingestion/src/datahub/ingestion/source/looker/looker_source.py
View File

@ -250,16 +250,11 @@ class LookerDashboardSource(TestableSource, StatefulIngestionSourceBase):
def test_connection(config_dict: dict) -> TestConnectionReport:
test_report = TestConnectionReport()
try:
self = cast(
LookerDashboardSource,
LookerDashboardSource.create(
config_dict, PipelineContext("looker-test-connection")
),
)
test_report.basic_connectivity = CapabilityReport(capable=True)
test_report.capability_report = {}
permissions = self.looker_api.get_available_permissions()
config = LookerDashboardSourceConfig.parse_obj_allow_extras(config_dict)
permissions = LookerAPI(config).get_available_permissions()
BASIC_INGEST_REQUIRED_PERMISSIONS = {
# TODO: Make this a bit more granular.