yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-25 09:00:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest): okta - make async loop init more robust (#5640)

Browse Source
This commit is contained in:
Shirshanka Das 2022-08-12 17:35:53 -07:00 committed by GitHub
parent a991dc9491
commit 63a3745010
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
metadata-ingestion/src/datahub/ingestion/source/identity/okta.py
View File

@ -46,13 +46,11 @@ logger = logging.getLogger(__name__)
class OktaConfig(ConfigModel): class OktaConfig(ConfigModel):
# Required: Domain of the Okta deployment. Example: dev-33231928.okta.com # Required: Domain of the Okta deployment. Example: dev-33231928.okta.com
okta_domain: str = Field( okta_domain: str = Field(
default="dev-33231928.okta.com", description="The location of your Okta Domain, without a protocol. Can be found in Okta Developer console. e.g. dev-33231928.okta.com",
description="The location of your Okta Domain, without a protocol. Can be found in Okta Developer console.",
) )
# Required: An API token generated from Okta. # Required: An API token generated from Okta.
okta_api_token: str = Field( okta_api_token: str = Field(
default="00be4R_M2MzDqXawbWgfKGpKee0kuEOfX1RCQSRx00", description="An API token generated for the DataHub application inside your Okta Developer Console. e.g. 00be4R_M2MzDqXawbWgfKGpKee0kuEOfX1RCQSRx00",
description="An API token generated for the DataHub application inside your Okta Developer Console.",
) )
# Optional: Whether to ingest users, groups, or both. # Optional: Whether to ingest users, groups, or both.
@ -263,8 +261,15 @@ class OktaSource(Source):
def get_workunits(self) -> Iterable[MetadataWorkUnit]: def get_workunits(self) -> Iterable[MetadataWorkUnit]:
# Step 0: create the event loop # Step 0: get or create the event loop
event_loop: asyncio.AbstractEventLoop = asyncio.get_event_loop() # This method can be called on the main thread or an async thread, so we must create a new loop if one doesn't exist
# See https://docs.python.org/3/library/asyncio-eventloop.html for more info.
try:
event_loop: asyncio.AbstractEventLoop = asyncio.get_event_loop()
except RuntimeError:
event_loop = asyncio.new_event_loop()
asyncio.set_event_loop(event_loop)
# Step 1: Produce MetadataWorkUnits for CorpGroups. # Step 1: Produce MetadataWorkUnits for CorpGroups.
if self.config.ingest_groups: if self.config.ingest_groups: