yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-26 17:37:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): fix a too much recursion error when column lineage is highlighted (#8207)

Browse Source 
Co-authored-by: Chris Collins <chriscollins3456@gmail.com>
This commit is contained in:
Felix Lüdin 2023-07-10 19:47:46 +02:00 committed by GitHub
parent d92cbe99e0
commit 64697eb5a0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
datahub-web-react/src/app/lineage/utils/highlightColumnLineage.ts
View File

@ -1,5 +1,5 @@
import { isEqual } from 'lodash';
import { ColumnEdge } from '../types';
import { isSameColumn } from './columnLineageUtils';
function highlightDownstreamColumnLineage(
sourceField: string,
@ -12,8 +12,9 @@ function highlightDownstreamColumnLineage(
Object.entries(forwardLineage).forEach((entry) => {
const [targetUrn, fieldPaths] = entry;
(fieldPaths as string[]).forEach((targetField) => {
edges.push({ sourceUrn, sourceField, targetUrn, targetField });
if (!isSameColumn({ sourceUrn, targetUrn, sourceField, targetField })) {
const edge: ColumnEdge = { sourceUrn, sourceField, targetUrn, targetField };
if (!edges.some((value) => isEqual(value, edge))) {
edges.push(edge);
highlightDownstreamColumnLineage(targetField, targetUrn, edges, fineGrainedMap);
}
});
@ -32,8 +33,9 @@ function highlightUpstreamColumnLineage(
Object.entries(reverseLineage).forEach((entry) => {
const [sourceUrn, fieldPaths] = entry;
(fieldPaths as string[]).forEach((sourceField) => {
edges.push({ targetUrn, targetField, sourceUrn, sourceField });
if (!isSameColumn({ sourceUrn, targetUrn, sourceField, targetField })) {
const edge: ColumnEdge = { sourceUrn, sourceField, targetUrn, targetField };
if (!edges.some((value) => isEqual(value, edge))) {
edges.push(edge);
highlightUpstreamColumnLineage(sourceField, sourceUrn, edges, fineGrainedMap);
}
});