yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-27 01:48:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(ci): try Qodana Scan for quality (#7560)

Browse Source
This commit is contained in:
Aseem Bansal 2023-03-14 14:26:06 +05:30 committed by GitHub
parent 81ec296b06
commit 64b4d0bace
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 39 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
.github/workflows/qodana-scan.yml vendored Normal file
View File

@ -0,0 +1,18 @@
name: Qodana
on:
workflow_dispatch:
pull_request:
push:
branches:
- master
jobs:
qodana:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2022.3.4
- uses: github/codeql-action/upload-sarif@v2
with:
sarif_file: ${{ runner.temp }}/qodana/results/qodana.sarif.json

28
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/mutate/DescriptionUtils.java
View File

@ -114,7 +114,9 @@ public class DescriptionUtils {
CorpGroupEditableInfo corpGroupEditableInfo =
(CorpGroupEditableInfo) getAspectFromEntity(
resourceUrn.toString(), Constants.CORP_GROUP_EDITABLE_INFO_ASPECT_NAME, entityService, new CorpGroupEditableInfo());
corpGroupEditableInfo.setDescription(newDescription);
if (corpGroupEditableInfo != null) {
corpGroupEditableInfo.setDescription(newDescription);
}
persistAspect(resourceUrn, Constants.CORP_GROUP_EDITABLE_INFO_ASPECT_NAME, corpGroupEditableInfo, actor, entityService);
}
@ -156,7 +158,9 @@ public class DescriptionUtils {
EntityService entityService) {
EditableNotebookProperties notebookProperties = (EditableNotebookProperties) getAspectFromEntity(
resourceUrn.toString(), Constants.EDITABLE_NOTEBOOK_PROPERTIES_ASPECT_NAME, entityService, null);
notebookProperties.setDescription(newDescription);
if (notebookProperties != null) {
notebookProperties.setDescription(newDescription);
}
persistAspect(resourceUrn, Constants.EDITABLE_NOTEBOOK_PROPERTIES_ASPECT_NAME, notebookProperties, actor, entityService);
}
@ -290,7 +294,9 @@ public class DescriptionUtils {
EntityService entityService) {
EditableMLModelProperties editableProperties = (EditableMLModelProperties) getAspectFromEntity(
resourceUrn.toString(), Constants.ML_MODEL_EDITABLE_PROPERTIES_ASPECT_NAME, entityService, new EditableMLModelProperties());
editableProperties.setDescription(newDescription);
if (editableProperties != null) {
editableProperties.setDescription(newDescription);
}
persistAspect(resourceUrn, Constants.ML_MODEL_EDITABLE_PROPERTIES_ASPECT_NAME, editableProperties, actor, entityService);
}
@ -301,7 +307,9 @@ public class DescriptionUtils {
EntityService entityService) {
EditableMLModelGroupProperties editableProperties = (EditableMLModelGroupProperties) getAspectFromEntity(
resourceUrn.toString(), Constants.ML_MODEL_GROUP_EDITABLE_PROPERTIES_ASPECT_NAME, entityService, new EditableMLModelGroupProperties());
editableProperties.setDescription(newDescription);
if (editableProperties != null) {
editableProperties.setDescription(newDescription);
}
persistAspect(resourceUrn, Constants.ML_MODEL_GROUP_EDITABLE_PROPERTIES_ASPECT_NAME, editableProperties, actor, entityService);
}
public static void updateMlFeatureDescription(
@ -311,7 +319,9 @@ public class DescriptionUtils {
EntityService entityService) {
EditableMLFeatureProperties editableProperties = (EditableMLFeatureProperties) getAspectFromEntity(
resourceUrn.toString(), Constants.ML_FEATURE_EDITABLE_PROPERTIES_ASPECT_NAME, entityService, new EditableMLFeatureProperties());
editableProperties.setDescription(newDescription);
if (editableProperties != null) {
editableProperties.setDescription(newDescription);
}
persistAspect(resourceUrn, Constants.ML_FEATURE_EDITABLE_PROPERTIES_ASPECT_NAME, editableProperties, actor, entityService);
}
@ -322,7 +332,9 @@ public class DescriptionUtils {
EntityService entityService) {
EditableMLFeatureTableProperties editableProperties = (EditableMLFeatureTableProperties) getAspectFromEntity(
resourceUrn.toString(), Constants.ML_FEATURE_TABLE_EDITABLE_PROPERTIES_ASPECT_NAME, entityService, new EditableMLFeatureTableProperties());
editableProperties.setDescription(newDescription);
if (editableProperties != null) {
editableProperties.setDescription(newDescription);
}
persistAspect(resourceUrn, Constants.ML_FEATURE_TABLE_EDITABLE_PROPERTIES_ASPECT_NAME, editableProperties, actor, entityService);
}
@ -333,7 +345,9 @@ public class DescriptionUtils {
EntityService entityService) {
EditableMLPrimaryKeyProperties editableProperties = (EditableMLPrimaryKeyProperties) getAspectFromEntity(
resourceUrn.toString(), Constants.ML_PRIMARY_KEY_EDITABLE_PROPERTIES_ASPECT_NAME, entityService, new EditableMLPrimaryKeyProperties());
editableProperties.setDescription(newDescription);
if (editableProperties != null) {
editableProperties.setDescription(newDescription);
}
persistAspect(resourceUrn, Constants.ML_PRIMARY_KEY_EDITABLE_PROPERTIES_ASPECT_NAME, editableProperties, actor, entityService);
}
}