Merge pull request #1433 from cptran777/various-ux-fixes

Various ux fixes
This commit is contained in:
Charlie Tran 2018-10-02 13:28:10 -07:00 committed by GitHub
commit 68e58b709a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 39 additions and 9 deletions

View File

@ -113,6 +113,9 @@
}
&__profile {
$max-profile-width: 108px;
display: flex;
&__pic {
float: left;
margin-right: 6px;
@ -121,10 +124,10 @@
&__name {
float: left;
max-width: 108px;
max-width: $max-profile-width;
&__full {
max-width: 108px;
max-width: $max-profile-width;
font-size: 16px;
font-weight: 400;
white-space: nowrap;
@ -135,6 +138,9 @@
&__username {
font-size: 14px;
max-width: $max-profile-width;
overflow: hidden;
text-overflow: ellipsis;
}
}
}

View File

@ -1,5 +1,5 @@
.dataset-pill {
& + & {
& {
> a {
@include on-event(true) {
color: inherit;

View File

@ -1,5 +1,25 @@
.dataset-relationships-container {
margin-top: item-spacing(5);
.relationship-table {
$cell-spacing: item-spacing(8);
&__type {
width: $cell-spacing * 3;
}
&__platform {
width: $cell-spacing * 2;
}
&__actor {
width: $cell-spacing * 3;
}
&__modified {
width: $cell-spacing * 3;
}
}
}
.dataset-relationships {

View File

@ -179,7 +179,7 @@
foldedChangeSet=(readonly foldedChangeSet)
unspecifiedTags=(readonly unspecifiedTags)
setUnspecifiedTagsAsNoneTask=setUnspecifiedTagsAsNoneTask
toggleEditing=toggleEditing
toggleEditing=(action toggleEditing)
showGuidedEditMode=(action "onShowGuidedEditMode")
fieldReviewChange=(action "onFieldReviewChange")}}
{{partial "datasets/dataset-compliance/dataset-compliance-entities"}}

View File

@ -1,7 +1,7 @@
{{#dataset-table fields=filteredRelationships as |relationTable|}}
{{#dataset-table fields=filteredRelationships class="relationship-table" as |relationTable|}}
{{#relationTable.head as |head|}}
{{#head.column}}Dataset{{/head.column}}
{{#head.column}}
{{#head.column class="relationship-table__dataset"}}Dataset{{/head.column}}
{{#head.column class="relationship-table__type"}}
{{#nacho/dropdown/hover-dropdown
dropDownItems=relationshipTypes
@ -11,8 +11,9 @@
{{/nacho/dropdown/hover-dropdown}}
{{/head.column}}
{{#head.column}}Actor{{/head.column}}
{{#head.column}}Last Modified{{/head.column}}
{{#head.column class="relationship-table__platform"}}Platform{{/head.column}}
{{#head.column class="relationship-table__actor"}}Actor{{/head.column}}
{{#head.column class="relationship-table__modified"}}Last Modified{{/head.column}}
{{/relationTable.head}}
{{#relationTable.body as |body|}}
@ -28,6 +29,9 @@
{{#row.cell}}
{{titleize lineage.type}}
{{/row.cell}}
{{#row.cell}}
{{titleize lineage.dataset.platform}}
{{/row.cell}}
{{#row.cell}}
{{lineage.actor}}
{{/row.cell}}