yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-09 17:20:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1433 from cptran777/various-ux-fixes

Browse Source 
Various ux fixes
This commit is contained in:
Charlie Tran 2018-10-02 13:28:10 -07:00 committed by GitHub
commit 68e58b709a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 39 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
wherehows-web/app/styles/components/dataset-author/_suggested-owners.scss
View File

@ -113,6 +113,9 @@
} }
&__profile { &__profile {
$max-profile-width: 108px;
display: flex;
&__pic { &__pic {
float: left; float: left;
margin-right: 6px; margin-right: 6px;
@ -121,10 +124,10 @@
&__name { &__name {
float: left; float: left;
max-width: 108px; max-width: $max-profile-width;
&__full { &__full {
max-width: 108px; max-width: $max-profile-width;
font-size: 16px; font-size: 16px;
font-weight: 400; font-weight: 400;
white-space: nowrap; white-space: nowrap;
@ -135,6 +138,9 @@
&__username { &__username {
font-size: 14px; font-size: 14px;
max-width: $max-profile-width;
overflow: hidden;
text-overflow: ellipsis;
} }
} }
} }

2
wherehows-web/app/styles/components/dataset-property/_dataset-pill.scss
View File

@ -1,5 +1,5 @@
.dataset-pill { .dataset-pill {
& + & { & {
> a { > a {
@include on-event(true) { @include on-event(true) {
color: inherit; color: inherit;

20
wherehows-web/app/styles/components/dataset-relationships/_dataset-relationships.scss
View File

@ -1,5 +1,25 @@
.dataset-relationships-container { .dataset-relationships-container {
margin-top: item-spacing(5); margin-top: item-spacing(5);
.relationship-table {
$cell-spacing: item-spacing(8);
&__type {
width: $cell-spacing * 3;
}
&__platform {
width: $cell-spacing * 2;
}
&__actor {
width: $cell-spacing * 3;
}
&__modified {
width: $cell-spacing * 3;
}
}
} }
.dataset-relationships { .dataset-relationships {

2
wherehows-web/app/templates/components/dataset-compliance.hbs
View File

@ -179,7 +179,7 @@
foldedChangeSet=(readonly foldedChangeSet) foldedChangeSet=(readonly foldedChangeSet)
unspecifiedTags=(readonly unspecifiedTags) unspecifiedTags=(readonly unspecifiedTags)
setUnspecifiedTagsAsNoneTask=setUnspecifiedTagsAsNoneTask setUnspecifiedTagsAsNoneTask=setUnspecifiedTagsAsNoneTask
toggleEditing=toggleEditing toggleEditing=(action toggleEditing)
showGuidedEditMode=(action "onShowGuidedEditMode") showGuidedEditMode=(action "onShowGuidedEditMode")
fieldReviewChange=(action "onFieldReviewChange")}} fieldReviewChange=(action "onFieldReviewChange")}}
{{partial "datasets/dataset-compliance/dataset-compliance-entities"}} {{partial "datasets/dataset-compliance/dataset-compliance-entities"}}

14
wherehows-web/app/templates/components/datasets/dataset-relationship-table.hbs
View File

@ -1,7 +1,7 @@
{{#dataset-table fields=filteredRelationships as |relationTable|}} {{#dataset-table fields=filteredRelationships class="relationship-table" as |relationTable|}}
{{#relationTable.head as |head|}} {{#relationTable.head as |head|}}
{{#head.column}}Dataset{{/head.column}} {{#head.column class="relationship-table__dataset"}}Dataset{{/head.column}}
{{#head.column}} {{#head.column class="relationship-table__type"}}
{{#nacho/dropdown/hover-dropdown {{#nacho/dropdown/hover-dropdown
dropDownItems=relationshipTypes dropDownItems=relationshipTypes
@ -11,8 +11,9 @@
{{/nacho/dropdown/hover-dropdown}} {{/nacho/dropdown/hover-dropdown}}
{{/head.column}} {{/head.column}}
{{#head.column}}Actor{{/head.column}} {{#head.column class="relationship-table__platform"}}Platform{{/head.column}}
{{#head.column}}Last Modified{{/head.column}} {{#head.column class="relationship-table__actor"}}Actor{{/head.column}}
{{#head.column class="relationship-table__modified"}}Last Modified{{/head.column}}
{{/relationTable.head}} {{/relationTable.head}}
{{#relationTable.body as |body|}} {{#relationTable.body as |body|}}
@ -28,6 +29,9 @@
{{#row.cell}} {{#row.cell}}
{{titleize lineage.type}} {{titleize lineage.type}}
{{/row.cell}} {{/row.cell}}
{{#row.cell}}
{{titleize lineage.dataset.platform}}
{{/row.cell}}
{{#row.cell}} {{#row.cell}}
{{lineage.actor}} {{lineage.actor}}
{{/row.cell}} {{/row.cell}}