diff --git a/datahub-web-react/src/app/ingest/source/builder/RecipeForm/SecretField/SecretField.tsx b/datahub-web-react/src/app/ingest/source/builder/RecipeForm/SecretField/SecretField.tsx index 07f5270574..ac1fe2166f 100644 --- a/datahub-web-react/src/app/ingest/source/builder/RecipeForm/SecretField/SecretField.tsx +++ b/datahub-web-react/src/app/ingest/source/builder/RecipeForm/SecretField/SecretField.tsx @@ -1,5 +1,5 @@ import React, { ReactNode } from 'react'; -import { Divider, Form, Select } from 'antd'; +import { AutoComplete, Divider, Form } from 'antd'; import styled from 'styled-components/macro'; import { Secret } from '../../../../../../types.generated'; import CreateSecretButton from './CreateSecretButton'; @@ -80,6 +80,8 @@ function SecretFieldTooltip({ tooltipLabel }: { tooltipLabel?: string | ReactNod } function SecretField({ field, secrets, removeMargin, refetchSecrets }: SecretFieldProps) { + const options = secrets.map((secret) => ({ value: `\${${secret.name}}`, label: secret.name })); + return ( - + /> ); } diff --git a/datahub-web-react/src/app/ingest/source/builder/RecipeForm/common.tsx b/datahub-web-react/src/app/ingest/source/builder/RecipeForm/common.tsx index 2bc5fedcf5..56a22f832a 100644 --- a/datahub-web-react/src/app/ingest/source/builder/RecipeForm/common.tsx +++ b/datahub-web-react/src/app/ingest/source/builder/RecipeForm/common.tsx @@ -56,7 +56,7 @@ function clearFieldAndParents(recipe: any, fieldPath: string | string[]) { export function setFieldValueOnRecipe(recipe: any, value: any, fieldPath: string | string[]) { const updatedRecipe = { ...recipe }; if (value !== undefined) { - if (value === null) { + if (value === null || value === '') { clearFieldAndParents(updatedRecipe, fieldPath); return updatedRecipe; }