yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-01 19:25:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest): mask password in info-level logs (#2835)

Browse Source
This commit is contained in:
Harshal Sheth 2021-07-06 16:41:54 -07:00 committed by GitHub
parent 288d17f07e
commit 6b59cdeb82
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
metadata-ingestion/README.md
View File

@ -504,7 +504,7 @@ source:
options: # options is same as above
# See https://github.com/mxmzdlv/pybigquery#authentication for details.
credentials_path: "/path/to/keyfile.json" # optional
include_views: True # whether to include views, defaults to True
include_views: True # whether to include views, defaults to True
# table_pattern/schema_pattern is same as above
```

2
metadata-ingestion/src/datahub/entrypoints.py
View File

@ -71,7 +71,7 @@ def ingest(config: str) -> None:
pipeline_config = load_config_file(config_file)
try:
logger.info(f"Using config: {pipeline_config}")
logger.debug(f"Using config: {pipeline_config}")
pipeline = Pipeline.create(pipeline_config)
except ValidationError as e:
click.echo(e, err=True)

5
metadata-ingestion/src/datahub/ingestion/source/sql_common.py
View File

@ -4,6 +4,7 @@ from dataclasses import dataclass, field
from typing import Any, Dict, Iterable, List, Optional, Set, Tuple, Type
from urllib.parse import quote_plus
import pydantic
from sqlalchemy import create_engine, inspect
from sqlalchemy.engine.reflection import Inspector
from sqlalchemy.sql import sqltypes as types
@ -116,7 +117,7 @@ class SQLAlchemyConfig(ConfigModel):
class BasicSQLAlchemyConfig(SQLAlchemyConfig):
username: Optional[str] = None
password: Optional[str] = None
password: Optional[pydantic.SecretStr] = None
host_port: str
database: Optional[str] = None
scheme: str
@ -125,7 +126,7 @@ class BasicSQLAlchemyConfig(SQLAlchemyConfig):
return make_sqlalchemy_uri(
self.scheme,
self.username,
self.password,
self.password.get_secret_value() if self.password else None,
self.host_port,
self.database,
uri_opts=uri_opts,