mirror of
https://github.com/datahub-project/datahub.git
synced 2025-10-13 18:04:55 +00:00
fix(ingestion/looker): handle potential None values in explore dataset entity (#14813)
This commit is contained in:
parent
50a231cd1a
commit
6bf511d8a8
@ -868,6 +868,7 @@ class LookerDashboardSource(TestableSource, StatefulIngestionSourceBase):
|
|||||||
):
|
):
|
||||||
explore_dataset_entity, explore_id, start_time, end_time = future.result()
|
explore_dataset_entity, explore_id, start_time, end_time = future.result()
|
||||||
self.reporter.explores_scanned += 1
|
self.reporter.explores_scanned += 1
|
||||||
|
if explore_dataset_entity:
|
||||||
yield explore_dataset_entity
|
yield explore_dataset_entity
|
||||||
self.reporter.report_upstream_latency(start_time, end_time)
|
self.reporter.report_upstream_latency(start_time, end_time)
|
||||||
logger.debug(
|
logger.debug(
|
||||||
@ -888,13 +889,14 @@ class LookerDashboardSource(TestableSource, StatefulIngestionSourceBase):
|
|||||||
def fetch_one_explore(
|
def fetch_one_explore(
|
||||||
self, model: str, explore: str
|
self, model: str, explore: str
|
||||||
) -> Tuple[
|
) -> Tuple[
|
||||||
Dataset,
|
Optional[Dataset],
|
||||||
str,
|
str,
|
||||||
datetime.datetime,
|
datetime.datetime,
|
||||||
datetime.datetime,
|
datetime.datetime,
|
||||||
]:
|
]:
|
||||||
start_time = datetime.datetime.now()
|
start_time = datetime.datetime.now()
|
||||||
looker_explore = self.explore_registry.get_explore(model, explore)
|
looker_explore = self.explore_registry.get_explore(model, explore)
|
||||||
|
explore_dataset_entity: Optional[Dataset] = None
|
||||||
if looker_explore is not None:
|
if looker_explore is not None:
|
||||||
explore_dataset_entity = looker_explore._to_metadata_events(
|
explore_dataset_entity = looker_explore._to_metadata_events(
|
||||||
self.source_config,
|
self.source_config,
|
||||||
|
Loading…
x
Reference in New Issue
Block a user