yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-13 01:48:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingestion/looker): handle potential None values in explore dataset entity (#14813)

Browse Source
This commit is contained in:
Anush Kumar 2025-09-18 15:08:07 -07:00 committed by GitHub
parent 50a231cd1a
commit 6bf511d8a8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
metadata-ingestion/src/datahub/ingestion/source/looker/looker_source.py
View File

@ -868,7 +868,8 @@ class LookerDashboardSource(TestableSource, StatefulIngestionSourceBase):
): ):
explore_dataset_entity, explore_id, start_time, end_time = future.result() explore_dataset_entity, explore_id, start_time, end_time = future.result()
self.reporter.explores_scanned += 1 self.reporter.explores_scanned += 1
yield explore_dataset_entity if explore_dataset_entity:
yield explore_dataset_entity
self.reporter.report_upstream_latency(start_time, end_time) self.reporter.report_upstream_latency(start_time, end_time)
logger.debug( logger.debug(
f"Running time of fetch_one_explore for {explore_id}: {(end_time - start_time).total_seconds()}" f"Running time of fetch_one_explore for {explore_id}: {(end_time - start_time).total_seconds()}"
@ -888,13 +889,14 @@ class LookerDashboardSource(TestableSource, StatefulIngestionSourceBase):
def fetch_one_explore( def fetch_one_explore(
self, model: str, explore: str self, model: str, explore: str
) -> Tuple[ ) -> Tuple[
Dataset, Optional[Dataset],
str, str,
datetime.datetime, datetime.datetime,
datetime.datetime, datetime.datetime,
]: ]:
start_time = datetime.datetime.now() start_time = datetime.datetime.now()
looker_explore = self.explore_registry.get_explore(model, explore) looker_explore = self.explore_registry.get_explore(model, explore)
explore_dataset_entity: Optional[Dataset] = None
if looker_explore is not None: if looker_explore is not None:
explore_dataset_entity = looker_explore._to_metadata_events( explore_dataset_entity = looker_explore._to_metadata_events(
self.source_config, self.source_config,