yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-31 12:45:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(secret-service): fix default encrypt key (#7074)

Browse Source
This commit is contained in:
david-leifker 2023-01-18 17:56:45 -06:00 committed by GitHub
parent e23eb7108f
commit 6d9da9b5e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
metadata-service/factories/src/main/resources/application.yml
View File

@ -44,7 +44,7 @@ telemetry:
enabledServer: ${DATAHUB_TELEMETRY_ENABLED:true}
secretService:
encryptionKey: "#{systemEnvironment['SECRET_SERVICE_ENCRYPTION_KEY']}:ENCRYPTION_KEY"
encryptionKey: "#{systemEnvironment['SECRET_SERVICE_ENCRYPTION_KEY'] ?: 'ENCRYPTION_KEY'}"
datahub:
serverType: ${DATAHUB_SERVER_TYPE:prod}

34
metadata-service/factories/src/test/java/com/linkedin/gms/factory/secret/SecretServiceFactoryTest.java Normal file
View File

@ -0,0 +1,34 @@
package com.linkedin.gms.factory.secret;
import com.linkedin.metadata.secret.SecretService;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.test.context.TestPropertySource;
import org.springframework.test.context.testng.AbstractTestNGSpringContextTests;
import org.testng.annotations.Test;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertNotNull;
@TestPropertySource(locations = "classpath:/application.yml")
@SpringBootTest(classes = {SecretServiceFactory.class})
public class SecretServiceFactoryTest extends AbstractTestNGSpringContextTests {
@Value("${secretService.encryptionKey}")
private String encryptionKey;
@Autowired
SecretService test;
@Test
void testInjection() throws IOException {
assertEquals(encryptionKey, "ENCRYPTION_KEY");
assertNotNull(test);
assertEquals(test.getHashedPassword("".getBytes(StandardCharsets.UTF_8), "password"),
"XohImNooBHFR0OVvjcYpJ3NgPQ1qq73WKhHvch0VQtg=");
}
}