yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-07-25 18:38:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleans up unit test for create search entries: removes global reference to server object on window, uses container instead. removes unused result variable. uses server.create inplace of createList since only one instance is used. deletes unneeded helper setup-mirage

Browse Source
This commit is contained in:
Seyi Adebajo 2018-05-14 23:47:00 -07:00
parent 73fba9f533
commit 6f9f003a0b
3 changed files with 12 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
wherehows-web/mirage/factories/dataset.js
View File

@ -1,5 +1,5 @@
import { Factory, faker, trait } from 'ember-cli-mirage'; import { Factory, faker, trait } from 'ember-cli-mirage';
import { testSchemaA } from '../data/schema'; import { testSchemaA } from 'wherehows-web/mirage/data/schema';
export default Factory.extend({ export default Factory.extend({
id: faker.random.number({ min: 10000, max: 20000 }), id: faker.random.number({ min: 10000, max: 20000 }),

5
wherehows-web/tests/helpers/setup-mirage.js
View File

@ -1,5 +0,0 @@
import mirageInitializer from 'wherehows-web/initializers/ember-cli-mirage';
export default function startMirage(container) {
mirageInitializer.initialize(container);
}

25
wherehows-web/tests/unit/utils/datasets/create-search-entries-test.js
View File

@ -1,37 +1,34 @@
import datasetsCreateSearchEntries from 'wherehows-web/utils/datasets/create-search-entries';
import { module, test } from 'qunit'; import { module, test } from 'qunit';
import startMirage from 'wherehows-web/tests/helpers/setup-mirage'; import { startMirage } from 'wherehows-web/initializers/ember-cli-mirage';
import datasetsCreateSearchEntries from 'wherehows-web/utils/datasets/create-search-entries';
import { testSchemaA } from 'wherehows-web/mirage/data/schema'; import { testSchemaA } from 'wherehows-web/mirage/data/schema';
module('Unit | Utility | datasets/create search entries', { module('Unit | Utility | datasets/create search entries', {
beforeEach() { beforeEach() {
startMirage(this.container); this.server = startMirage();
}, },
afterEach() { afterEach() {
window.server.shutdown(); this.server.shutdown();
} }
}); });
test('it works base case', function(assert) { test('it works base case', function(assert) {
const server = window.server; const { server } = this;
const model = server.createList('dataset', 1, 'forUnitTests'); const dataset = server.create('dataset', 'forUnitTests');
const dataset = model[0];
let result = datasetsCreateSearchEntries([]); const result = datasetsCreateSearchEntries([]);
assert.ok(!result, 'Returns without error for nothing case'); assert.ok(!result, 'Returns without error for nothing case');
result = datasetsCreateSearchEntries(model); datasetsCreateSearchEntries([dataset]);
assert.equal(dataset.id, 0, 'Sanity check: Created model successfully'); assert.equal(dataset.id, 0, 'Sanity check: Created model successfully');
assert.equal(dataset.originalSchema, testSchemaA, 'Preserves original schema properly');
assert.equal(dataset.schema, testSchemaA.slice(0, 499), 'Partial schema from beginning if no keyword found'); assert.equal(dataset.schema, testSchemaA.slice(0, 499), 'Partial schema from beginning if no keyword found');
}); });
test('it works for keyword cases', function(assert) { test('it works for keyword cases', function(assert) {
const server = window.server; const { server } = this;
const model = server.createList('dataset', 1, 'forUnitTests'); const dataset = server.create('dataset', 'forUnitTests');
const dataset = model[0];
let result = datasetsCreateSearchEntries(model, 'Rebel'); datasetsCreateSearchEntries([dataset], 'Rebel');
assert.equal(dataset.id, 0, 'Sanity check: Created model successfully again'); assert.equal(dataset.id, 0, 'Sanity check: Created model successfully again');
assert.equal(dataset.schema, testSchemaA.slice(29, 529), 'Partial schema starts from keyword index'); assert.equal(dataset.schema, testSchemaA.slice(29, 529), 'Partial schema starts from keyword index');
}); });