yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-04 23:00:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1129 from theseyi/disregard-none-suggested-for-multi-tag

Browse Source 
disregards suggested value of ComplianceFieldIdValue.None if the fiel…
This commit is contained in:
Seyi Adebajo 2018-05-01 13:18:28 -07:00 committed by GitHub
commit 720c2f5280
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
wherehows-web/app/components/dataset-compliance-rollup-row.ts
View File

@ -352,10 +352,13 @@ export default class DatasetComplianceRollupRow extends Component.extend({
value: <ComplianceFieldIdValue>identifierType value: <ComplianceFieldIdValue>identifierType
}); });
} else { } else {
// If suggested value is ComplianceFieldIdValue.None then do not add
if (identifierType !== ComplianceFieldIdValue.None) {
this.actions.onAddFieldTag.call(this, { identifierType, logicalType }); this.actions.onAddFieldTag.call(this, { identifierType, logicalType });
} }
} }
} }
}
// Invokes parent handle to ignore future revisits of this suggestion // Invokes parent handle to ignore future revisits of this suggestion
if (typeof onSuggestionIntent === 'function') { if (typeof onSuggestionIntent === 'function') {