yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-01 11:19:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #846 from theseyi/master

Browse Source 
update tracking header expression: adds case insensitive header, mobi…
This commit is contained in:
Seyi Adebajo 2017-11-08 19:13:18 -08:00 committed by GitHub
commit 720e6bfabc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
wherehows-web/app/utils/validators/tracking-headers.js
View File

@ -1,8 +0,0 @@
// Matches field identifiers starting with header, requestHeader, mobileHeader,
// mobile_header, request_header
// all optionally suffixed with a period and any non - line break characters
const trackingHeaderFieldsRegex = /^(?:header[.|[]|request_?header[.|[]|mobile_?header[.|[]).*/i;
export default candidateString => trackingHeaderFieldsRegex.test(String(candidateString));
export { trackingHeaderFieldsRegex };

16
wherehows-web/app/utils/validators/tracking-headers.ts Normal file
View File

@ -0,0 +1,16 @@
/**
* Matches field identifiers starting with header, requestHeader, mobileHeader,
* mobile_header, request_header
* or solely those strings
* optionally suffixed with a period and any non - line break characters
*/
const trackingHeaderFieldsRegex = /^(?:header$|header[.|[]|request_?header$|request_?header[.|[]|mobile_?header$|mobile_?header[.|[]).*/i;
/**
* Tests if the supplied string matches any of the tracking header regex'
* @param {string} candidateString
* @return {boolean}
*/
export default (candidateString: string): boolean => trackingHeaderFieldsRegex.test(String(candidateString));
export { trackingHeaderFieldsRegex };

14
wherehows-web/tests/helpers/validators/tracking-headers/constants.ts
View File

@ -1,6 +1,14 @@
const headers = ['header.', 'header[field]', 'header.field', 'header[]'];
const requestHeaders = ['requestheader[]', 'requestheader.', 'request_header.mockId', 'request_header.s[]'];
const headers = ['header', 'HEADER', 'header.', 'header[field]', 'header.field', 'header[]'];
const requestHeaders = [
'requestheader[]',
'requestheader.',
'request_header.mockId',
'request_header.s[]',
'requestheader'
];
const mobileHeaders = [
'mobileheader',
'MobileHeader',
'mobileheader.',
'MobileHeader[]',
'mobile_header.header',
@ -19,9 +27,7 @@ const trackingHeaderList = [...headers, ...requestHeaders, ...mobileHeaders];
* @type {Array<string>}
*/
const nonTrackingHeaderList = [
'header',
'headers',
'Header',
'headerfortrackingisinvalid',
'HEADER_PATH',
'HEADER_REFERER',