yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-31 10:49:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(ui) Update summary page editability (#14822)

Browse Source
This commit is contained in:
Chris Collins 2025-09-25 10:53:13 -04:00 committed by GitHub
parent 941b3c725a
commit 72ee770ae3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
datahub-web-react/src/app/homeV3/HomePageContent.tsx
View File

@ -11,7 +11,7 @@ const HomePageContent = () => {
<ContentContainer> <ContentContainer>
<CenteredContainer> <CenteredContainer>
<ContentDiv> <ContentDiv>
{/* <EditHomePageSettingsButton /> */} {/* <EditHomePageSettingsButton /> Editing templates is not enabled in OSS */}
<Announcements /> <Announcements />
<Template /> <Template />
<EditDefaultTemplateBar /> <EditDefaultTemplateBar />

8
datahub-web-react/src/app/homeV3/context/PageTemplateContext.tsx
View File

@ -1,6 +1,5 @@
import React, { ReactNode, createContext, useContext, useMemo } from 'react'; import React, { ReactNode, createContext, useContext, useMemo } from 'react';
import { useEntityData } from '@app/entity/shared/EntityContext';
import { useAssetSummaryOperations } from '@app/homeV3/context/hooks/useAssetSummaryOperations'; import { useAssetSummaryOperations } from '@app/homeV3/context/hooks/useAssetSummaryOperations';
import { useModuleModalState } from '@app/homeV3/context/hooks/useModuleModalState'; import { useModuleModalState } from '@app/homeV3/context/hooks/useModuleModalState';
import { useModuleOperations } from '@app/homeV3/context/hooks/useModuleOperations'; import { useModuleOperations } from '@app/homeV3/context/hooks/useModuleOperations';
@ -18,12 +17,7 @@ interface Props {
} }
export const PageTemplateProvider = ({ children, templateType }: Props) => { export const PageTemplateProvider = ({ children, templateType }: Props) => {
const { entityData } = useEntityData(); const isTemplateEditable = false; // template is not editable in OSS
const editable = !!entityData?.privileges?.canManageAssetSummary;
const isTemplateEditable = useMemo(
() => (templateType === PageTemplateSurfaceType.AssetSummary ? editable : false),
[editable, templateType],
);
// Template state management // Template state management
const { const {
personalTemplate, personalTemplate,