yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-01 13:23:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactors is id check in dataset compliance list generation. reenables component render for dataset owner list and removes false condition no known owners text

Browse Source
This commit is contained in:
Seyi Adebajo 2018-03-05 08:29:03 -08:00
parent 656fe9ae34
commit 73f0ea651f
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
wherehows-web/app/components/dataset-compliance.ts
View File

@ -334,8 +334,9 @@ export default class DatasetCompliance extends Component {
* @returns {Array<IComplianceFieldIdentifierOption>} * @returns {Array<IComplianceFieldIdentifierOption>}
*/ */
const insertDivider = (types: Array<IComplianceFieldIdentifierOption>): Array<IComplianceFieldIdentifierOption> => { const insertDivider = (types: Array<IComplianceFieldIdentifierOption>): Array<IComplianceFieldIdentifierOption> => {
const ids = types.filter(({ isId }) => isId); const isId = ({ isId }: IComplianceFieldIdentifierOption): boolean => isId;
const nonIds = types.filter(({ isId }) => !isId); const ids = types.filter(isId);
const nonIds = types.filter(type => !isId(type));
const divider = { const divider = {
value: '', value: '',
label: '---------', label: '---------',

2
wherehows-web/app/templates/components/dataset-owner-list.hbs
View File

@ -24,6 +24,4 @@
</a> </a>
</span> </span>
{{/if}} {{/if}}
{{else}}
No known owners
{{/if}} {{/if}}

3
wherehows-web/app/templates/datasets/dataset.hbs
View File

@ -41,10 +41,13 @@
{{/if}} {{/if}}
<h3 class="dataset-name"> <h3 class="dataset-name">
<div class="container">
{{model.nativeName}} {{model.nativeName}}
</div>
</h3> </h3>
</div> </div>
{{dataset-owner-list owners=owners datasetName=model.nativeName}}
</div> </div>
{{#ivy-tabs selection=tabSelected as |tabs|}} {{#ivy-tabs selection=tabSelected as |tabs|}}