yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-27 18:07:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): Render descriptions for custom assertions (#14383)

Browse Source
This commit is contained in:
Saketh Varma 2025-08-11 08:31:39 -07:00 committed by GitHub
parent adf00c199d
commit 744600b2d9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
datahub-web-react/src/app/entity/shared/tabs/Dataset/Validations/contract/DataQualityContractSummary.tsx
View File

@ -1,4 +1,4 @@
import { Table } from 'antd';
import { Table, Typography } from 'antd';
import React from 'react';
import styled from 'styled-components';
@ -10,7 +10,7 @@ import { VolumeAssertionDescription } from '@app/entity/shared/tabs/Dataset/Vali
import { DataContractAssertionStatus } from '@app/entity/shared/tabs/Dataset/Validations/contract/DataContractAssertionStatus';
import { DataContractSummaryFooter } from '@app/entity/shared/tabs/Dataset/Validations/contract/DataContractSummaryFooter';
import { Assertion, DataQualityContract, DatasetAssertionInfo } from '@types';
import { Assertion, AssertionType, DataQualityContract, DatasetAssertionInfo } from '@types';
const TitleText = styled.div`
color: ${ANTD_GRAY[7]};
@ -63,6 +63,9 @@ export const DataQualityContractSummary = ({ contracts, showAction = false }: Pr
<FieldAssertionDescription assertionInfo={assertion.info?.fieldAssertion} />
)}
{assertion.info?.sqlAssertion && <SqlAssertionDescription assertionInfo={assertion.info} />}
{assertion.info?.type === AssertionType.Custom && (
<Typography.Text>{assertion.info?.description}</Typography.Text>
)}
</>
),
},

7
datahub-web-react/src/app/entityV2/shared/tabs/Dataset/Validations/contract/DataQualityContractSummary.tsx
View File

@ -1,4 +1,4 @@
import { Table } from 'antd';
import { Table, Typography } from 'antd';
import React from 'react';
import styled from 'styled-components';
@ -10,7 +10,7 @@ import { VolumeAssertionDescription } from '@app/entityV2/shared/tabs/Dataset/Va
import { DataContractAssertionStatus } from '@app/entityV2/shared/tabs/Dataset/Validations/contract/DataContractAssertionStatus';
import { DataContractSummaryFooter } from '@app/entityV2/shared/tabs/Dataset/Validations/contract/DataContractSummaryFooter';
import { Assertion, DataQualityContract, DatasetAssertionInfo } from '@types';
import { Assertion, AssertionType, DataQualityContract, DatasetAssertionInfo } from '@types';
const TitleText = styled.div`
color: ${ANTD_GRAY[7]};
@ -63,6 +63,9 @@ export const DataQualityContractSummary = ({ contracts, showAction = false }: Pr
<FieldAssertionDescription assertionInfo={assertion.info?.fieldAssertion} />
)}
{assertion.info?.sqlAssertion && <SqlAssertionDescription assertionInfo={assertion.info} />}
{assertion.info?.type === AssertionType.Custom && (
<Typography.Text>{assertion.info?.description}</Typography.Text>
)}
</>
),
},