yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-08 23:43:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest): note that views are not supported for Athena (#2924)

Browse Source
This commit is contained in:
Harshal Sheth 2021-07-21 12:48:40 -07:00 committed by GitHub
parent ad30f2b8ec
commit 7535cf2b85
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
metadata-ingestion/README.md
View File

@ -552,7 +552,6 @@ source:
# See https://docs.aws.amazon.com/athena/latest/ug/querying.html # See https://docs.aws.amazon.com/athena/latest/ug/querying.html
# However, the athena driver will transparently fetch these results as you would expect from any other sql client. # However, the athena driver will transparently fetch these results as you would expect from any other sql client.
work_group: athena_workgroup # "primary" work_group: athena_workgroup # "primary"
include_views: True # whether to include views, defaults to True
# table_pattern/schema_pattern is same as above # table_pattern/schema_pattern is same as above
``` ```

2
metadata-ingestion/src/datahub/ingestion/source/athena.py
View File

@ -12,6 +12,8 @@ class AthenaConfig(SQLAlchemyConfig):
s3_staging_dir: str s3_staging_dir: str
work_group: str work_group: str
include_views = False # not supported for Athena
def get_sql_alchemy_url(self): def get_sql_alchemy_url(self):
return make_sqlalchemy_uri( return make_sqlalchemy_uri(
self.scheme, self.scheme,