yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-14 18:31:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes failing tests

Browse Source
This commit is contained in:
Seyi Adebajo 2020-02-02 21:55:55 -08:00 committed by Seyi Adebajo
parent 7d6a4b65f8
commit 7952a69f8b
2 changed files with 9 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
datahub-web/packages/data-portal/app/templates/components/datasets/dataset-header.hbs
View File

@ -2,13 +2,10 @@
<div class="container"> <div class="container">
<div class="dataset-meta-properties"> <div class="dataset-meta-properties">
<h3 class="dataset-name"> <h3 class="dataset-name">
{{compute {{@model.nativeName}}
(get (get-field-spec @fields "name") "compute")
@model
}}
</h3> </h3>
{{#if model.removed}} {{#if @model.removed}}
<span class="removed-dataset dataset-pill"> <span class="removed-dataset dataset-pill">
REMOVED REMOVED
@ -32,7 +29,7 @@
{{/if}} {{/if}}
{{#if model.deprecated}} {{#if @model.deprecated}}
<span class="deprecated-dataset dataset-pill"> <span class="deprecated-dataset dataset-pill">
{{#link-to "datasets.dataset.tab" encodedUrn "properties"}} {{#link-to "datasets.dataset.tab" encodedUrn "properties"}}

20
datahub-web/packages/data-portal/tests/integration/components/datasets/containers/dataset-ownership-test.js
View File

@ -3,37 +3,28 @@ import { setupRenderingTest } from 'ember-qunit';
import { render, waitUntil, find } from '@ember/test-helpers'; import { render, waitUntil, find } from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile'; import hbs from 'htmlbars-inline-precompile';
import { urn } from 'wherehows-web/mirage/fixtures/urn'; import { urn } from 'wherehows-web/mirage/fixtures/urn';
import sinon from 'sinon';
import { resetConfig, setMockConfig } from 'wherehows-web/services/configurator'; import { resetConfig, setMockConfig } from 'wherehows-web/services/configurator';
import { noop } from 'wherehows-web/utils/helpers/functions'; import { noop } from 'wherehows-web/utils/helpers/functions';
import { startMirage } from 'wherehows-web/initializers/ember-cli-mirage';
module('Integration | Component | datasets/containers/dataset ownership', function(hooks) { module('Integration | Component | datasets/containers/dataset ownership', function(hooks) {
setupRenderingTest(hooks); setupRenderingTest(hooks);
hooks.beforeEach(function() { hooks.beforeEach(function() {
setMockConfig({}); setMockConfig({});
this.sinonServer = sinon.createFakeServer();
this.sinonServer.respondImmediately = true;
}); });
hooks.afterEach(function() { hooks.afterEach(function() {
this.sinonServer.restore();
resetConfig(); resetConfig();
}); });
test('it renders', async function(assert) { test('it renders', async function(assert) {
const lookupClass = '.dataset-owner-table__add-owner'; const lookupClass = '.dataset-owner-table__add-owner';
this.setProperties({ urn: urn, setOwnershipRuleChange: noop }); this.setProperties({ urn: urn, setOwnershipRuleChange: noop });
this.sinonServer.respondWith('GET', /\/api\/v2\/datasets.*/, [ const mirage = startMirage();
200,
{ 'Content-Type': 'application/json' }, mirage.get('/api/v2/datasets', () => ({}));
JSON.stringify({}) mirage.get('/api/v1/owners/types/', () => []);
]);
this.sinonServer.respondWith('GET', '/api/v1/owner/types', [
200,
{ 'Content-Type': 'application/json' },
JSON.stringify([])
]);
await render(hbs`{{datasets/containers/dataset-ownership setOwnershipRuleChange=setOwnershipRuleChange urn=urn}}`); await render(hbs`{{datasets/containers/dataset-ownership setOwnershipRuleChange=setOwnershipRuleChange urn=urn}}`);
@ -43,5 +34,6 @@ module('Integration | Component | datasets/containers/dataset ownership', functi
'Add an owner', 'Add an owner',
'shows dataset authors component' 'shows dataset authors component'
); );
mirage.shutdown();
}); });
}); });