From 795d76b56ca1723a8710cdbcdb21024a88c0c084 Mon Sep 17 00:00:00 2001 From: Harshal Sheth Date: Fri, 3 Mar 2023 14:54:42 -0500 Subject: [PATCH] fix(ingest/tableau): load project workbook hierarchy correctly (#7483) --- .../src/datahub/ingestion/source/tableau.py | 11 +++-------- .../src/datahub/ingestion/source/tableau_common.py | 2 ++ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/metadata-ingestion/src/datahub/ingestion/source/tableau.py b/metadata-ingestion/src/datahub/ingestion/source/tableau.py index 327337c9f2..a7820664e2 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/tableau.py +++ b/metadata-ingestion/src/datahub/ingestion/source/tableau.py @@ -2091,12 +2091,7 @@ class TableauSource(StatefulIngestionSourceBase): ] ) dashboard_snapshot.aspects.append(browse_paths) - else: - logger.warning( - f"Could not set browse path for dashboard {dashboard[tableau_constant.ID]}. Please check permissions." - ) - - if ( + elif ( workbook is not None and workbook.get(tableau_constant.PROJECT_NAME) and workbook.get(tableau_constant.NAME) @@ -2110,8 +2105,8 @@ class TableauSource(StatefulIngestionSourceBase): ) dashboard_snapshot.aspects.append(browse_paths) else: - logger.debug( - f"Browse path not set for dashboard {dashboard[tableau_constant.ID]}" + logger.warning( + f"Could not set browse path for dashboard {dashboard[tableau_constant.ID]}. Please check permissions." ) # Ownership diff --git a/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py b/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py index 663a4f6fd9..48c6b43483 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py +++ b/metadata-ingestion/src/datahub/ingestion/source/tableau_common.py @@ -85,6 +85,7 @@ sheet_graphql_query = """ id name projectName + projectLuid owner { username } @@ -162,6 +163,7 @@ dashboard_graphql_query = """ id name projectName + projectLuid owner { username }