yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-12 09:23:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixes rendering of tooltips for edit button and expand/collapse chevrons in compliance table

Browse Source
This commit is contained in:
Seyi Adebajo 2018-05-02 18:44:58 -07:00
parent 3037028bd6
commit 7b0924d184
2 changed files with 16 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
wherehows-web/app/styles/components/dataset-compliance/_compliance-table.scss
View File

@ -253,6 +253,7 @@
&__edit { &__edit {
display: flex; display: flex;
align-items: center;
} }
&__prop { &__prop {

15
wherehows-web/app/templates/datasets/dataset-compliance/-dataset-compliance-entities.hbs
View File

@ -123,18 +123,17 @@
{{#row.cell}} {{#row.cell}}
<div class="dataset-compliance-fields__id-field-wrap"> <div class="dataset-compliance-fields__id-field-wrap">
{{#if isReadOnly}} {{#if (and isReadOnly (not row.isReadonly))}}
<div class="dataset-compliance-fields__id-field-wrap__edit"> <div class="dataset-compliance-fields__id-field-wrap__edit">
<span class="nacho-tooltip" title="Edit Fields">
<button <button
class="nacho-button nacho-button--tertiary dataset-compliance-fields__rollup-toggle" class="nacho-button nacho-button--tertiary dataset-compliance-fields__rollup-toggle"
onclick={{action row.onEditPolicy (action "nextStep")}}> onclick={{action row.onEditPolicy (action "nextStep")}}>
<span class="nacho-tooltip" title="Edit Policy"> <i class="fa fa-pencil" aria-label="Edit Fields"></i>
<i class="fa fa-pencil" aria-label="Edit Policy"></i>
</span>
</button> </button>
</span>
</div> </div>
{{/if}} {{/if}}
@ -214,20 +213,18 @@
{{/row.cell}} {{/row.cell}}
{{#row.cell}} {{#row.cell}}
<span class="nacho-tooltip" title="{{if row.isRowExpanded 'Collapse field' 'Expand field'}}">
<button <button
class="nacho-button nacho-button--tertiary dataset-compliance-fields__rollup-toggle" class="nacho-button nacho-button--tertiary dataset-compliance-fields__rollup-toggle"
onclick={{action row.onToggleRowExpansion}}> onclick={{action row.onToggleRowExpansion}}>
<span class="nacho-tooltip" text="{{if row.isRowExpanded 'Collapse field' 'Expand field'}}">
{{#if row.isRowExpanded}} {{#if row.isRowExpanded}}
<i class="glyphicon glyphicon-menu-up" aria-label="Expand field"></i> <i class="glyphicon glyphicon-menu-up" aria-label="Expand field"></i>
{{else}} {{else}}
<i class="glyphicon glyphicon-menu-down" aria-label="Collapse field"></i> <i class="glyphicon glyphicon-menu-down" aria-label="Collapse field"></i>
{{/if}} {{/if}}
</span>
</button> </button>
</span>
{{/row.cell}} {{/row.cell}}
</tr> </tr>