yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-08 15:30:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Modify FE compliance suggestion API response (#800)

Browse Source
This commit is contained in:
Yi (Alan) Wang 2017-10-16 21:34:01 -07:00 committed by GitHub
parent 48c274ede3
commit 7b8715e7ec
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
wherehows-dao/src/main/java/wherehows/dao/table/DatasetComplianceDao.java
View File

@ -96,7 +96,7 @@ public class DatasetComplianceDao extends BaseDao {
} }
public DsComplianceSuggestion findComplianceSuggestionByUrn(@Nonnull String datasetUrn) { public DsComplianceSuggestion findComplianceSuggestionByUrn(@Nonnull String datasetUrn) {
return null; throw new UnsupportedOperationException("Compliance Suggestion not implemented.");
} }
/** /**
@ -110,5 +110,6 @@ public class DatasetComplianceDao extends BaseDao {
public void insertUpdateSuggestedCompliance(@Nonnull DatasetIdentifier identifier, int datasetId, @Nonnull ChangeAuditStamp auditStamp, public void insertUpdateSuggestedCompliance(@Nonnull DatasetIdentifier identifier, int datasetId, @Nonnull ChangeAuditStamp auditStamp,
@Nonnull SuggestedCompliancePolicy suggestion) throws Exception { @Nonnull SuggestedCompliancePolicy suggestion) throws Exception {
// TODO: write suggested compliance information to DB // TODO: write suggested compliance information to DB
throw new UnsupportedOperationException("Compliance Suggestion not implemented.");
} }
} }

14
wherehows-frontend/app/controllers/api/v1/Dataset.java
View File

@ -13,15 +13,12 @@
*/ */
package controllers.api.v1; package controllers.api.v1;
import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.JsonNode; import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.node.ArrayNode; import com.fasterxml.jackson.databind.node.ArrayNode;
import com.fasterxml.jackson.databind.node.ObjectNode; import com.fasterxml.jackson.databind.node.ObjectNode;
import controllers.Application; import controllers.Application;
import dao.AbstractMySQLOpenSourceDAO; import dao.AbstractMySQLOpenSourceDAO;
import dao.DatasetsDAO; import dao.DatasetsDAO;
import java.io.IOException;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
@ -40,12 +37,11 @@ import wherehows.dao.table.DatasetComplianceDao;
import wherehows.dao.table.DatasetsDao; import wherehows.dao.table.DatasetsDao;
import wherehows.dao.view.DatasetViewDao; import wherehows.dao.view.DatasetViewDao;
import wherehows.dao.view.OwnerViewDao; import wherehows.dao.view.OwnerViewDao;
import wherehows.models.table.DatasetClassification;
import wherehows.models.view.DatasetColumn;
import wherehows.models.table.DatasetCompliance; import wherehows.models.table.DatasetCompliance;
import wherehows.models.table.DatasetDependency; import wherehows.models.table.DatasetDependency;
import wherehows.models.view.DatasetOwner;
import wherehows.models.table.ImpactDataset; import wherehows.models.table.ImpactDataset;
import wherehows.models.view.DatasetColumn;
import wherehows.models.view.DatasetOwner;
import wherehows.models.view.DsComplianceSuggestion; import wherehows.models.view.DsComplianceSuggestion;
@ -874,8 +870,12 @@ public class Dataset extends Controller {
return Promise.promise(() -> ok(result)); return Promise.promise(() -> ok(result));
} }
JsonNode result = Json.newObject().put("status", "ok").set("complianceSuggestion", Json.toJson(record)); if (record == null) {
JsonNode result = Json.newObject().put("status", "failed").put("msg", "Not found");
return Promise.promise(() -> ok(result));
}
JsonNode result = Json.newObject().put("status", "ok").set("complianceSuggestion", Json.toJson(record));
return Promise.promise(() -> ok(result)); return Promise.promise(() -> ok(result));
} }
} }