yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-23 00:28:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(neo4j): Improve test performance (#6142)

Browse Source 
Reuse neo4j graph service in test for performance improvements.
This commit is contained in:
david-leifker 2022-10-24 10:49:06 -05:00 committed by GitHub
parent ac6779989a
commit 7cdc9f7fcf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
metadata-io/src/main/java/com/linkedin/metadata/graph/neo4j/Neo4jGraphService.java
View File

@ -3,6 +3,7 @@ package com.linkedin.metadata.graph.neo4j;
import com.codahale.metrics.Timer; import com.codahale.metrics.Timer;
import com.datahub.util.Statement; import com.datahub.util.Statement;
import com.datahub.util.exception.RetryLimitReached; import com.datahub.util.exception.RetryLimitReached;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableMap;
import com.linkedin.common.urn.Urn; import com.linkedin.common.urn.Urn;
import com.linkedin.metadata.graph.Edge; import com.linkedin.metadata.graph.Edge;
@ -254,6 +255,11 @@ public class Neo4jGraphService implements GraphService {
removeNodesMatchingLabel(".*"); removeNodesMatchingLabel(".*");
} }
@VisibleForTesting
public void wipe() {
runQuery(new Statement("MATCH (n) DETACH DELETE n", Map.of())).consume();
}
// visible for testing // visible for testing
@Nonnull @Nonnull
Statement buildStatement(@Nonnull String queryTemplate, @Nonnull Map<String, Object> params) { Statement buildStatement(@Nonnull String queryTemplate, @Nonnull Map<String, Object> params) {

13
metadata-io/src/test/java/com/linkedin/metadata/graph/neo4j/Neo4jGraphServiceTest.java
View File

@ -10,7 +10,8 @@ import com.linkedin.metadata.query.filter.RelationshipFilter;
import org.neo4j.driver.Driver; import org.neo4j.driver.Driver;
import org.neo4j.driver.GraphDatabase; import org.neo4j.driver.GraphDatabase;
import org.testng.SkipException; import org.testng.SkipException;
import org.testng.annotations.AfterMethod; import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.BeforeMethod; import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test; import org.testng.annotations.Test;
@ -28,15 +29,21 @@ public class Neo4jGraphServiceTest extends GraphServiceTestBase {
private Driver _driver; private Driver _driver;
private Neo4jGraphService _client; private Neo4jGraphService _client;
@BeforeMethod @BeforeClass
public void init() { public void init() {
_serverBuilder = new Neo4jTestServerBuilder(); _serverBuilder = new Neo4jTestServerBuilder();
_serverBuilder.newServer(); _serverBuilder.newServer();
_driver = GraphDatabase.driver(_serverBuilder.boltURI()); _driver = GraphDatabase.driver(_serverBuilder.boltURI());
_client = new Neo4jGraphService(new LineageRegistry(SnapshotEntityRegistry.getInstance()), _driver); _client = new Neo4jGraphService(new LineageRegistry(SnapshotEntityRegistry.getInstance()), _driver);
_client.clear();
} }
@AfterMethod @BeforeMethod
public void wipe() {
_client.wipe();
}
@AfterClass
public void tearDown() { public void tearDown() {
_serverBuilder.shutdown(); _serverBuilder.shutdown();
} }