From 7d1ec520e55e7d28efd39d5bf5116517c9dfe7a8 Mon Sep 17 00:00:00 2001 From: Harshal Sheth Date: Tue, 20 Apr 2021 20:40:30 -0700 Subject: [PATCH] fix(ingest): include database info for snowflake (#2426) --- metadata-ingestion/README.md | 1 + .../src/datahub/ingestion/source/snowflake.py | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/metadata-ingestion/README.md b/metadata-ingestion/README.md index f698473ad7..7170c660bc 100644 --- a/metadata-ingestion/README.md +++ b/metadata-ingestion/README.md @@ -261,6 +261,7 @@ source: username: user password: pass host_port: account_name + database: db_name # table_pattern/schema_pattern is same as above # options is same as above ``` diff --git a/metadata-ingestion/src/datahub/ingestion/source/snowflake.py b/metadata-ingestion/src/datahub/ingestion/source/snowflake.py index ba5f2504d0..d4ac553e77 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/snowflake.py +++ b/metadata-ingestion/src/datahub/ingestion/source/snowflake.py @@ -5,9 +5,14 @@ from .sql_common import BasicSQLAlchemyConfig, SQLAlchemySource class SnowflakeConfig(BasicSQLAlchemyConfig): - # defaults scheme = "snowflake" + database: str # database is required + + def get_identifier(self, schema: str, table: str) -> str: + regular = super().get_identifier(schema, table) + return f"{self.database}.{regular}" + class SnowflakeSource(SQLAlchemySource): def __init__(self, config, ctx):