From 83d9f7d6e660e19db3d00baf16e532c7117794ab Mon Sep 17 00:00:00 2001 From: Shirshanka Das Date: Tue, 31 May 2022 14:42:56 -0700 Subject: [PATCH] fix(ingest): fix build breakage due to traitlets 5.2.2 bug (#5051) --- metadata-ingestion/scripts/docgen.py | 5 +++-- metadata-ingestion/setup.py | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/metadata-ingestion/scripts/docgen.py b/metadata-ingestion/scripts/docgen.py index f2f64270a5..4a0303abb7 100644 --- a/metadata-ingestion/scripts/docgen.py +++ b/metadata-ingestion/scripts/docgen.py @@ -531,8 +531,9 @@ def generate( get_additional_deps_for_extra(extra_plugin) if extra_plugin else [] ) except Exception as e: - print(f"Failed to process {plugin_name} due to {e}") - metrics["plugins"]["failed"] = metrics["plugins"]["failed"] + 1 + print(f"Failed to process {plugin_name} due to exception") + print(repr(e)) + metrics["plugins"]["failed"] = metrics["plugins"].get("failed", 0) + 1 if source_type and hasattr(source_type, "get_config_class"): try: diff --git a/metadata-ingestion/setup.py b/metadata-ingestion/setup.py index 1e6a12ccd2..e8f1c04353 100644 --- a/metadata-ingestion/setup.py +++ b/metadata-ingestion/setup.py @@ -91,6 +91,9 @@ sql_common = { "great-expectations>=0.14.11,<0.15.3", # datahub does not depend on Jinja2 directly but great expectations does. With Jinja2 3.1.0 GE 0.14.11 is breaking "Jinja2<3.1.0", + # datahub does not depend on traitlets directly but great expectations does. + # https://github.com/ipython/traitlets/issues/741 + "traitlets<5.2.2", "greenlet", }