yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-08 16:48:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest): fix some typos and logging issues (#5564)

Browse Source
This commit is contained in:
Harshal Sheth 2022-08-04 04:01:45 +00:00 committed by GitHub
parent 16ff4aaa94
commit 858b132444
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
metadata-ingestion/src/datahub/ingestion/run/pipeline.py
View File

@ -124,7 +124,7 @@ class Pipeline:
def _record_initialization_failure(self, e: Exception, msg: str) -> None: def _record_initialization_failure(self, e: Exception, msg: str) -> None:
self.pipeline_init_exception: Optional[Exception] = e self.pipeline_init_exception: Optional[Exception] = e
self.pipeline_init_failures: Optional[str] = f"{msg} due to {e}" self.pipeline_init_failures: Optional[str] = f"{msg} due to {e}"
logger.error(e) logger.exception(e)
def __init__( def __init__(
self, self,

4
metadata-ingestion/src/datahub/ingestion/source/sql/sql_common.py
View File

@ -773,7 +773,7 @@ class SQLAlchemySource(StatefulIngestionSourceBase):
self, *, schema: str, entity: str, inspector: Inspector, **kwargs: Any self, *, schema: str, entity: str, inspector: Inspector, **kwargs: Any
) -> str: ) -> str:
# Many SQLAlchemy dialects have three-level hierarchies. This method, which # Many SQLAlchemy dialects have three-level hierarchies. This method, which
# subclasses can override, enables them to modify the identifers as needed. # subclasses can override, enables them to modify the identifiers as needed.
if hasattr(self.config, "get_identifier"): if hasattr(self.config, "get_identifier"):
# This path is deprecated and will eventually be removed. # This path is deprecated and will eventually be removed.
return self.config.get_identifier(schema=schema, table=entity) # type: ignore return self.config.get_identifier(schema=schema, table=entity) # type: ignore
@ -1209,7 +1209,7 @@ class SQLAlchemySource(StatefulIngestionSourceBase):
canonical_schema=schema_fields, canonical_schema=schema_fields,
) )
try: try:
# SQLALchemy stubs are incomplete and missing this method. # SQLAlchemy stubs are incomplete and missing this method.
# PR: https://github.com/dropbox/sqlalchemy-stubs/pull/223. # PR: https://github.com/dropbox/sqlalchemy-stubs/pull/223.
view_info: dict = inspector.get_table_comment(view, schema) # type: ignore view_info: dict = inspector.get_table_comment(view, schema) # type: ignore
except NotImplementedError: except NotImplementedError: