yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-22 15:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(search): clear description from dataset index when it's cleared (#1808)

Browse Source 
Fixes https://github.com/linkedin/datahub/issues/1798
This commit is contained in:
Mars Lan 2020-08-14 07:09:27 -07:00 committed by GitHub
parent 18a3892736
commit 872ca3598a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
metadata-builders/src/main/java/com/linkedin/metadata/builders/search/DatasetIndexBuilder.java
View File

@ -72,6 +72,8 @@ public class DatasetIndexBuilder extends BaseIndexBuilder<DatasetDocument> {
final DatasetDocument doc = setUrnDerivedFields(urn); final DatasetDocument doc = setUrnDerivedFields(urn);
if (datasetProperties.hasDescription()) { if (datasetProperties.hasDescription()) {
doc.setDescription(datasetProperties.getDescription()); doc.setDescription(datasetProperties.getDescription());
} else {
doc.setDescription("");
} }
return doc; return doc;
} }

40
metadata-builders/src/test/java/com/linkedin/metadata/builders/search/DatasetIndexBuilderTest.java Normal file
View File

@ -0,0 +1,40 @@
package com.linkedin.metadata.builders.search;
import com.linkedin.common.FabricType;
import com.linkedin.common.urn.DataPlatformUrn;
import com.linkedin.common.urn.DatasetUrn;
import com.linkedin.dataset.DatasetProperties;
import com.linkedin.metadata.aspect.DatasetAspect;
import com.linkedin.metadata.dao.utils.ModelUtils;
import com.linkedin.metadata.search.DatasetDocument;
import com.linkedin.metadata.snapshot.DatasetSnapshot;
import java.util.Collections;
import java.util.List;
import org.testng.annotations.Test;
import static org.testng.Assert.*;
public class DatasetIndexBuilderTest {
@Test
public void testDescriptionClearing() {
DatasetUrn datasetUrn = new DatasetUrn(new DataPlatformUrn("foo"), "bar", FabricType.PROD);
DatasetProperties datasetProperties = new DatasetProperties().setDescription("baz");
DatasetSnapshot datasetSnapshot = ModelUtils.newSnapshot(DatasetSnapshot.class, datasetUrn,
Collections.singletonList(ModelUtils.newAspectUnion(DatasetAspect.class, datasetProperties)));
List<DatasetDocument> actualDocs = new DatasetIndexBuilder().getDocumentsToUpdate(datasetSnapshot);
assertEquals(actualDocs.size(), 1);
assertEquals(actualDocs.get(0).getUrn(), datasetUrn);
assertEquals(actualDocs.get(0).getDescription(), "baz");
datasetProperties = new DatasetProperties();
datasetSnapshot = ModelUtils.newSnapshot(DatasetSnapshot.class, datasetUrn,
Collections.singletonList(ModelUtils.newAspectUnion(DatasetAspect.class, datasetProperties)));
actualDocs = new DatasetIndexBuilder().getDocumentsToUpdate(datasetSnapshot);
assertEquals(actualDocs.size(), 1);
assertEquals(actualDocs.get(0).getUrn(), datasetUrn);
assertEquals(actualDocs.get(0).getDescription(), "");
}
}