From 8b36ab0fcec41a70e76d93661f99e8581bf15c23 Mon Sep 17 00:00:00 2001 From: Seyi Adebajo Date: Mon, 19 Mar 2018 10:04:29 -0700 Subject: [PATCH] makes nonOwner compliance entity attribute nullable --- wherehows-web/app/components/dataset-compliance-row.ts | 3 ++- wherehows-web/app/components/dataset-compliance.ts | 2 +- wherehows-web/app/typings/api/datasets/compliance.d.ts | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/wherehows-web/app/components/dataset-compliance-row.ts b/wherehows-web/app/components/dataset-compliance-row.ts index f6fae05d8b..5a8337301b 100644 --- a/wherehows-web/app/components/dataset-compliance-row.ts +++ b/wherehows-web/app/components/dataset-compliance-row.ts @@ -20,6 +20,7 @@ import { IComplianceDataType } from 'wherehows-web/typings/api/list/compliance-d import { getFieldSuggestions } from 'wherehows-web/utils/datasets/compliance-suggestions'; import noop from 'wherehows-web/utils/noop'; import { hasEnumerableKeys } from 'wherehows-web/utils/object'; +import { IComplianceEntity } from 'wherehows-web/typings/api/datasets/compliance'; /** * Constant definition for an unselected field format @@ -89,7 +90,7 @@ export default class DatasetComplianceRow extends DatasetTableRow { * @type {ComputedProperty} * @memberof DatasetComplianceRow */ - nonOwner: ComputedProperty = alias('field.nonOwner').readOnly(); + nonOwner: ComputedProperty = alias('field.nonOwner').readOnly(); /** * The field's dataType attribute diff --git a/wherehows-web/app/components/dataset-compliance.ts b/wherehows-web/app/components/dataset-compliance.ts index ab526edc7e..3b7f2bd80c 100644 --- a/wherehows-web/app/components/dataset-compliance.ts +++ b/wherehows-web/app/components/dataset-compliance.ts @@ -906,7 +906,7 @@ export default class DatasetCompliance extends Component { identifierType: ComplianceFieldIdValue.None, logicalType: null, securityClassification: null, - nonOwner: false + nonOwner: null })); const confirmHandler = (function() { diff --git a/wherehows-web/app/typings/api/datasets/compliance.d.ts b/wherehows-web/app/typings/api/datasets/compliance.d.ts index fc78532499..0341ea6359 100644 --- a/wherehows-web/app/typings/api/datasets/compliance.d.ts +++ b/wherehows-web/app/typings/api/datasets/compliance.d.ts @@ -27,7 +27,7 @@ export interface IComplianceEntity { // User specified / default security classification for the related schema field securityClassification: Classification | null; // Flag indicating that the dataset is of a subject type, default is false - nonOwner: boolean; + nonOwner: boolean | null; // Flag indicating that this compliance field is not editable by the end user // field should also be filtered from persisted policy readonly readonly?: boolean;