yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-03 12:16:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): safely access caught Error properties (#3196)

Browse Source
This commit is contained in:
Aikepaer Abuduweili 2021-09-07 23:14:59 -07:00 committed by GitHub
parent 8747fbe43c
commit 8dbbec45a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
datahub-web-react/src/app/entity/dataset/profile/schema/components/SchemaDescriptionField.tsx
View File

@ -101,9 +101,9 @@ export default function DescriptionField({
await onUpdate(desc || '');
// message.destroy();
// message.success({ content: 'Updated!', duration: 2 });
} catch (e) {
} catch (e: unknown) {
message.destroy();
message.error({ content: `Update Failed! \n ${e.message || ''}`, duration: 2 });
if (e instanceof Error) message.error({ content: `Update Failed! \n ${e.message || ''}`, duration: 2 });
}
onCloseModal();
};

4
datahub-web-react/src/app/entity/shared/components/legacy/UpdatableDescription.tsx
View File

@ -47,9 +47,9 @@ export default function UpdatableDescription({
entityUrn: urn,
});
message.success({ content: 'Updated!', duration: 2 });
} catch (e) {
} catch (e: unknown) {
message.destroy();
message.error({ content: `Update Failed! \n ${e.message || ''}`, duration: 2 });
if (e instanceof Error) message.error({ content: `Update Failed! \n ${e.message || ''}`, duration: 2 });
}
setShowAddDescModal(false);
};

6
datahub-web-react/src/app/entity/shared/components/styled/AddLinkModal.tsx
View File

@ -47,9 +47,11 @@ export const AddLinkModal = ({ buttonProps }: { buttonProps?: Record<string, unk
variables: { input: { urn, institutionalMemory: { elements: newLinks } } },
});
message.success({ content: 'Link Added', duration: 2 });
} catch (e) {
} catch (e: unknown) {
message.destroy();
message.error({ content: `Failed to add link: \n ${e.message || ''}`, duration: 3 });
if (e instanceof Error) {
message.error({ content: `Failed to add link: \n ${e.message || ''}`, duration: 3 });
}
}
handleClose();

6
datahub-web-react/src/app/entity/shared/tabs/Documentation/components/DescriptionEditor.tsx
View File

@ -32,9 +32,11 @@ export const DescriptionEditor = ({ onComplete }: { onComplete?: () => void }) =
});
message.success({ content: 'Description Updated', duration: 2 });
if (onComplete) onComplete();
} catch (e) {
} catch (e: unknown) {
message.destroy();
message.error({ content: `Failed to update description: \n ${e.message || ''}`, duration: 2 });
if (e instanceof Error) {
message.error({ content: `Failed to update description: \n ${e.message || ''}`, duration: 2 });
}
}
};

6
datahub-web-react/src/app/entity/shared/tabs/Documentation/components/LinkList.tsx
View File

@ -53,9 +53,11 @@ export const LinkList = () => {
variables: { input: { urn, institutionalMemory: { elements: newLinks } } },
});
message.success({ content: 'Link Deleted', duration: 2 });
} catch (e) {
} catch (e: unknown) {
message.destroy();
message.error({ content: `Error deleting link: \n ${e.message || ''}`, duration: 2 });
if (e instanceof Error) {
message.error({ content: `Error deleting link: \n ${e.message || ''}`, duration: 2 });
}
}
};