yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-19 22:58:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(ui): Show message when related glossary terms are empty. (#5285)

Browse Source
This commit is contained in:
Ankit keshari 2022-06-29 23:17:30 +05:30 committed by GitHub
parent 9e58cd6ff1
commit 8e79a89355
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
datahub-web-react/src/app/entity/glossaryTerm/profile/GlossaryRelatedTermsResult.tsx
View File

@ -4,6 +4,7 @@ import React, { useState } from 'react';
import styled from 'styled-components/macro';
import { TermRelationshipType } from '../../../../types.generated';
import { Message } from '../../../shared/Message';
import { EmptyTab } from '../../shared/components/styled/EmptyTab';
import { ANTD_GRAY } from '../../shared/constants';
import AddRelatedTermsModal from './AddRelatedTermsModal';
import RelatedTerm from './RelatedTerm';
@ -62,6 +63,9 @@ export default function GlossaryRelatedTermsResult({ glossaryRelatedTermType, gl
{glossaryRelatedTermUrns.map((urn) => (
<RelatedTerm key={urn} urn={urn} relationshipType={relationshipType} />
))}
{glossaryRelatedTermUrns.length === 0 && (
<EmptyTab tab={glossaryRelatedTermType.toLocaleLowerCase()} />
)}
</ListContainer>
)}
{isShowingAddModal && (

8
datahub-web-react/src/app/entity/shared/constants.ts
View File

@ -47,4 +47,12 @@ export const EMPTY_MESSAGES = {
title: 'No domain set',
description: 'Group related entities based on your organizational structure using by adding them to a Domain.',
},
contains: {
title: 'Contains no Terms',
description: 'Terms can contain other terms to represent an "Has A" style relationship.',
},
inherits: {
title: 'Does not inherit from any terms',
description: 'Terms can inherit from other terms to represent an "Is A" style relationship.',
},
};

3
datahub-web-react/src/app/entity/shared/containers/profile/header/PlatformContent/PlatformContentView.tsx
View File

@ -6,6 +6,7 @@ import { Maybe } from 'graphql/jsutils/Maybe';
import { Container } from '../../../../../../../types.generated';
import { ANTD_GRAY } from '../../../../constants';
import ContainerLink from './ContainerLink';
import { capitalizeFirstLetter } from '../../../../../../shared/textUtil';
const LogoIcon = styled.span`
display: flex;
@ -119,7 +120,7 @@ function PlatformContentView(props: Props) {
return (
<PlatformContentWrapper>
{typeIcon && <LogoIcon>{typeIcon}</LogoIcon>}
<PlatformText>{entityType}</PlatformText>
<PlatformText>{capitalizeFirstLetter(entityType)}</PlatformText>
{(!!platformName || !!instanceId || !!parentContainers?.length) && <PlatformDivider />}
{platformName && (
<LogoIcon>