yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-29 02:48:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(logs): add thresholding, misc cleanup (#2773)

Browse Source
This commit is contained in:
John Joyce 2021-06-25 11:51:59 -07:00 committed by GitHub
parent 29be54330c
commit 942196e3c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 40 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
datahub-frontend/app/react/controllers/GraphQLController.java
View File

@ -105,9 +105,9 @@ public class GraphQLController extends Controller {
executionResult.toSpecification(),
executionResult.getErrors()));
} else {
_logger.debug(String.format("Executed graphQL query: %s, result: %s"),
_logger.debug(String.format("Executed graphQL query: %s, result: %s",
queryJson,
executionResult.toSpecification());
executionResult.toSpecification()));
}

19
datahub-frontend/conf/logback.xml
View File

@ -7,6 +7,9 @@
<layout class="ch.qos.logback.classic.PatternLayout">
<pattern>%d{HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
</layout>
<filter class="ch.qos.logback.classic.filter.ThresholdFilter">
<level>INFO</level>
</filter>
</appender>
<appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
@ -20,6 +23,9 @@
<!-- 30 days to keep -->
<maxHistory>30</maxHistory>
</rollingPolicy>
<filter class="ch.qos.logback.classic.filter.ThresholdFilter">
<level>INFO</level>
</filter>
<encoder>
<pattern>%d{HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
</encoder>
@ -38,6 +44,8 @@
</rollingPolicy>
<filter class="ch.qos.logback.classic.filter.LevelFilter">
<level>DEBUG</level>
<onMatch>ACCEPT</onMatch>
<onMismatch>DENY</onMismatch>
</filter>
<encoder>
<pattern>%d{HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
@ -45,21 +53,20 @@
</appender>
<!-- Change this to disable logging debug -->
<logger name="com.linkedin" level="debug">
<logger name="com.linkedin" level="DEBUG">
<appender-ref ref="DEBUG_FILE"/>
</logger>
<logger name="controller" level="debug">
<logger name="controller" level="DEBUG">
<appender-ref ref="DEBUG_FILE"/>
</logger>
<logger name="graphql" level="debug">
<logger name="graphql" level="DEBUG">
<appender-ref ref="DEBUG_FILE"/>
</logger>
<logger name="react" level="debug">
<logger name="react" level="DEBUG">
<appender-ref ref="DEBUG_FILE"/>
</logger>
<!-- Change this to disable logging debug -->
<root level="info">
<root level="INFO">
<appender-ref ref="STDOUT"/>
<appender-ref ref="FILE"/>
</root>

18
datahub-frontend/run/logback.xml
View File

@ -7,6 +7,9 @@
<layout class="ch.qos.logback.classic.PatternLayout">
<pattern>%d{HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
</layout>
<filter class="ch.qos.logback.classic.filter.ThresholdFilter">
<level>INFO</level>
</filter>
</appender>
<appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
@ -20,6 +23,9 @@
<!-- 30 days to keep -->
<maxHistory>30</maxHistory>
</rollingPolicy>
<filter class="ch.qos.logback.classic.filter.ThresholdFilter">
<level>INFO</level>
</filter>
<encoder>
<pattern>%d{HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
</encoder>
@ -38,6 +44,8 @@
</rollingPolicy>
<filter class="ch.qos.logback.classic.filter.LevelFilter">
<level>DEBUG</level>
<onMatch>ACCEPT</onMatch>
<onMismatch>DENY</onMismatch>
</filter>
<encoder>
<pattern>%d{HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
@ -45,20 +53,20 @@
</appender>
<!-- Change this to disable logging debug -->
<logger name="com.linkedin" level="debug">
<logger name="com.linkedin" level="DEBUG">
<appender-ref ref="DEBUG_FILE"/>
</logger>
<logger name="controller" level="debug">
<logger name="controller" level="DEBUG">
<appender-ref ref="DEBUG_FILE"/>
</logger>
<logger name="graphql" level="debug">
<logger name="graphql" level="DEBUG">
<appender-ref ref="DEBUG_FILE"/>
</logger>
<logger name="react" level="debug">
<logger name="react" level="DEBUG">
<appender-ref ref="DEBUG_FILE"/>
</logger>
<root level="info">
<root level="INFO">
<appender-ref ref="STDOUT"/>
<appender-ref ref="FILE"/>
</root>

2
gms/impl/src/main/java/com/linkedin/metadata/filter/LoggingFilter.java
View File

@ -52,7 +52,7 @@ public class LoggingFilter implements Filter {
String method = requestContext.getMethod().getName();
String uri = requestContext.getRequestURI().toString();
String logStr = String.format("%s %s - %s - %s - %sms", httpMethod, uri, method, status, duration);
String logStr = String.format("%s %s - %s - %s - %sms", httpMethod, uri, method, status.getCode(), duration);
log.info(logStr);
}

2
gms/impl/src/main/java/com/linkedin/metadata/resources/lineage/Relationships.java
View File

@ -25,7 +25,6 @@ import java.net.URISyntaxException;
import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors;
import lombok.extern.slf4j.Slf4j;
import static com.linkedin.metadata.dao.Neo4jUtil.*;
import static com.linkedin.metadata.dao.utils.QueryUtils.newFilter;
@ -34,7 +33,6 @@ import static com.linkedin.metadata.dao.utils.QueryUtils.newFilter;
/**
* Rest.li entry point: /relationships?type={entityType}&direction={direction}&types={types}
*/
@Slf4j
@RestLiSimpleResource(name = "relationships", namespace = "com.linkedin.lineage")
public final class Relationships extends SimpleResourceTemplate<EntityRelationships> {

15
gms/war/src/main/resources/logback.xml
View File

@ -5,6 +5,9 @@
<encoder>
<pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern>
</encoder>
<filter class="ch.qos.logback.classic.filter.ThresholdFilter">
<level>INFO</level>
</filter>
</appender>
<appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
@ -18,7 +21,9 @@
<!-- 30 days to keep -->
<maxHistory>30</maxHistory>
</rollingPolicy>
<filter class="ch.qos.logback.classic.filter.ThresholdFilter">
<level>INFO</level>
</filter>
<encoder>
<pattern>%d{HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
</encoder>
@ -37,6 +42,8 @@
</rollingPolicy>
<filter class="ch.qos.logback.classic.filter.LevelFilter">
<level>DEBUG</level>
<onMatch>ACCEPT</onMatch>
<onMismatch>DENY</onMismatch>
</filter>
<encoder>
<pattern>%d{HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
@ -44,15 +51,15 @@
</appender>
<!-- Remove this to disable logging debug -->
<logger name="com.linkedin" level="debug">
<logger name="com.linkedin" level="DEBUG">
<appender-ref ref="DEBUG_FILE"/>
</logger>
<logger name="org.apache.kafka.clients" level="info">
<logger name="org.apache.kafka.clients" level="INFO">
<appender-ref ref="STDOUT" />
</logger>
<root level="info">
<root level="INFO">
<appender-ref ref="STDOUT" />
<appender-ref ref="FILE"/>
</root>