yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-25 08:58:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Business Glossary): updated glossary term search strategy (#2973)

Browse Source
This commit is contained in:
Lal Rishav 2021-08-06 12:01:06 +05:30 committed by GitHub
parent 1fbc80bd39
commit 94b35fe8a0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/glossary/mappers/GlossaryTermSnapshotMapper.java
View File

@ -31,7 +31,7 @@ public class GlossaryTermSnapshotMapper implements ModelMapper<GlossaryTermSnaps
result.setUrn(glossaryTerm.getUrn().toString());
result.setType(EntityType.GLOSSARY_TERM);
result.setName(GlossaryTermUtils.getGlossaryTermName(glossaryTerm.getUrn().getNameEntity()));
result.setHierarchicalName(glossaryTerm.getUrn().getNameEntity());
ModelUtils.getAspectsFromSnapshot(glossaryTerm).forEach(aspect -> {
if (aspect instanceof GlossaryTermInfo) {
result.setGlossaryTermInfo(GlossaryTermInfoMapper.map(GlossaryTermInfo.class.cast(aspect)));

5
datahub-graphql-core/src/main/resources/gms.graphql
View File

@ -384,6 +384,11 @@ type GlossaryTerm implements Entity {
"""
name: String!
"""
hierarchicalName of glossary term
"""
hierarchicalName: String!
"""
Details of the Glossary Term
"""

2
datahub-web-react/src/Mocks.tsx
View File

@ -301,6 +301,7 @@ export const dataset3 = {
type: EntityType.GlossaryTerm,
urn: 'urn:li:glossaryTerm:sample-glossary-term',
name: 'sample-glossary-term',
hierarchicalName: 'example.sample-glossary-term',
glossaryTermInfo: {
definition: 'sample definition',
termSource: 'sample term source',
@ -529,6 +530,7 @@ const glossaryTerm1 = {
urn: 'urn:li:glossaryTerm:1',
type: EntityType.GlossaryTerm,
name: 'Another glossary term',
hierarchicalName: 'example.AnotherGlossaryTerm',
ownership: {
owners: [
{

1
datahub-web-react/src/app/entity/dataset/profile/stories/sampleSchema.ts
View File

@ -122,6 +122,7 @@ export const sampleSchemaWithTags: Schema = {
type: EntityType.GlossaryTerm,
urn: 'urn:li:glossaryTerm:sample-glossary-term',
name: 'sample-glossary-term',
hierarchicalName: 'example.sample-glossary-term',
glossaryTermInfo: {
definition: 'sample definition',
termSource: 'sample term source',

4
datahub-web-react/src/app/entity/glossaryTerm/profile/GlossaryTermProfile.tsx
View File

@ -28,10 +28,10 @@ export default function GlossaryTermProfile() {
const searchTypes = entityRegistry.getSearchEntityTypes();
searchTypes.splice(searchTypes.indexOf(EntityType.GlossaryTerm), 1);
const glossaryTermName = data?.glossaryTerm?.name;
const glossaryTermHierarchicalName = data?.glossaryTerm?.hierarchicalName;
const entitySearchResult = useGetEntitySearchResults(
{
query: `${glossaryTermName}`,
query: `glossaryTerms:"${glossaryTermHierarchicalName}"`,
},
searchTypes,
);

1
datahub-web-react/src/graphql/glossaryTerm.graphql
View File

@ -3,6 +3,7 @@ query getGlossaryTerm($urn: String!) {
urn
type
name
hierarchicalName
ownership {
...ownershipFields
}

2
metadata-models/src/main/pegasus/com/linkedin/common/GlossaryTermAssociation.pdl
View File

@ -9,7 +9,7 @@ record GlossaryTermAssociation {
*/
@Searchable = {
"fieldName": "glossaryTerms",
"fieldType": "TEXT_PARTIAL"
"fieldType": "URN_PARTIAL"
}
urn: GlossaryTermUrn
}