From 94de04deab9e1560f797fb0072467de1efa68795 Mon Sep 17 00:00:00 2001 From: Ignacio Bona Date: Mon, 17 Sep 2018 10:54:11 -0700 Subject: [PATCH] PR feedback comments --- .../app/components/search/containers/search-facets.ts | 4 ++-- wherehows-web/app/components/search/search-facet.ts | 6 +++--- .../app/templates/components/search/search-facet.hbs | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/wherehows-web/app/components/search/containers/search-facets.ts b/wherehows-web/app/components/search/containers/search-facets.ts index 32cd3b608f..b8a41280d5 100644 --- a/wherehows-web/app/components/search/containers/search-facets.ts +++ b/wherehows-web/app/components/search/containers/search-facets.ts @@ -32,8 +32,8 @@ interface ISearchFacet { * It will store state related to search facets. */ export default class SearchFacetsContainer extends Component { - didInsertElement(this: SearchFacetsContainer) { - get(this, 'getPlatformsTask').perform(); + didInsertElement() { + this.getPlatformsTask.perform(); } /** diff --git a/wherehows-web/app/components/search/search-facet.ts b/wherehows-web/app/components/search/search-facet.ts index 0ba1433267..83cd84360b 100644 --- a/wherehows-web/app/components/search/search-facet.ts +++ b/wherehows-web/app/components/search/search-facet.ts @@ -16,10 +16,10 @@ export default class SearchFacet extends Component { * facet. If that is the case, a clear button will show up. */ @computed('selections') - get showClear(): boolean { + get showClearBtn(): boolean { const selections = this.selections || {}; - return Object.keys(selections).reduce((willShowClear: boolean, selectionKey: string) => { - return willShowClear || selections[selectionKey]; + return Object.keys(selections).reduce((willShowClearBtn: boolean, selectionKey: string) => { + return willShowClearBtn || selections[selectionKey]; }, false); } } diff --git a/wherehows-web/app/templates/components/search/search-facet.hbs b/wherehows-web/app/templates/components/search/search-facet.hbs index 53116b6f86..6c012fa651 100644 --- a/wherehows-web/app/templates/components/search/search-facet.hbs +++ b/wherehows-web/app/templates/components/search/search-facet.hbs @@ -1,7 +1,7 @@

{{facet.displayName}}

- {{#if showClear}} + {{#if showClearBtn}}