yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-02 13:53:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixes issue with low confidence suggestion not being filtered out for review required fields

Browse Source
This commit is contained in:
Seyi Adebajo 2018-05-23 16:17:50 -07:00
parent 4cb324861a
commit 96422df404
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
wherehows-web/app/constants/dataset-compliance.ts
View File

@ -22,6 +22,7 @@ import {
} from 'wherehows-web/typings/app/dataset-columns';
import { IDatasetColumn } from 'wherehows-web/typings/api/datasets/columns';
import { ComplianceFieldIdValue } from 'wherehows-web/constants/datasets/compliance';
import { isHighConfidenceSuggestion } from 'wherehows-web/utils/datasets/compliance-suggestions';
/**
* Defines a map of values for the compliance policy on a dataset
@ -199,8 +200,8 @@ const tagNeedsReview = (complianceDataTypes: Array<IComplianceDataType>) =>
return true;
}
// Check that suggestion exists and the identifierType does not match the change set item
if (suggestion && suggestion.identifierType !== identifierType) {
// Check that a hi confidence suggestion exists and the identifierType does not match the change set item
if (suggestion && suggestion.identifierType !== identifierType && isHighConfidenceSuggestion(suggestion)) {
isReviewRequired = isReviewRequired || !suggestionAuthority;
}