yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-26 01:23:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(delete): support deleting by search w/ tokens (#3684)

Browse Source
This commit is contained in:
Gabe Lyons 2021-12-07 14:31:52 -08:00 committed by GitHub
parent b3ef5ee489
commit 98366cca1f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
metadata-ingestion/src/datahub/cli/cli_utils.py
View File

@ -97,6 +97,17 @@ def guess_entity_type(urn: str) -> str:
return urn.split(":")[2] return urn.split(":")[2]
def get_token():
_, gms_token_env = get_details_from_env()
if should_skip_config():
gms_token = gms_token_env
else:
ensure_datahub_config()
_, gms_token_conf = get_details_from_config()
gms_token = first_non_null([gms_token_env, gms_token_conf])
return gms_token
def get_session_and_host(): def get_session_and_host():
session = requests.Session() session = requests.Session()

7
metadata-ingestion/src/datahub/cli/delete_cli.py
View File

@ -186,8 +186,10 @@ def delete_with_filters(
) -> DeletionResult: ) -> DeletionResult:
session, gms_host = cli_utils.get_session_and_host() session, gms_host = cli_utils.get_session_and_host()
token = cli_utils.get_token()
logger.info(f"datahub configured with {gms_host}") logger.info(f"datahub configured with {gms_host}")
emitter = rest_emitter.DatahubRestEmitter(gms_server=gms_host) emitter = rest_emitter.DatahubRestEmitter(gms_server=gms_host, token=token)
batch_deletion_result = DeletionResult() batch_deletion_result = DeletionResult()
urns = [ urns = [
u u
@ -238,7 +240,8 @@ def delete_one_urn(
# Add removed aspect # Add removed aspect
if not cached_emitter: if not cached_emitter:
_, gms_host = cli_utils.get_session_and_host() _, gms_host = cli_utils.get_session_and_host()
emitter = rest_emitter.DatahubRestEmitter(gms_server=gms_host) token = cli_utils.get_token()
emitter = rest_emitter.DatahubRestEmitter(gms_server=gms_host, token=token)
else: else:
emitter = cached_emitter emitter = cached_emitter
if not dry_run: if not dry_run: