From 9a2e990bedc6915b1cc8c9f25927ab901b682efc Mon Sep 17 00:00:00 2001 From: Harshal Sheth Date: Fri, 12 May 2023 10:12:22 +0530 Subject: [PATCH] fix(sdk): throw errors on empty gms server urls (#8017) --- metadata-ingestion/src/datahub/emitter/rest_emitter.py | 4 ++-- metadata-ingestion/src/datahub_provider/hooks/datahub.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/metadata-ingestion/src/datahub/emitter/rest_emitter.py b/metadata-ingestion/src/datahub/emitter/rest_emitter.py index 2b5eea7308..fa7ea58c7d 100644 --- a/metadata-ingestion/src/datahub/emitter/rest_emitter.py +++ b/metadata-ingestion/src/datahub/emitter/rest_emitter.py @@ -61,13 +61,13 @@ class DataHubRestEmitter(Closeable): retry_max_times: Optional[int] = None, extra_headers: Optional[Dict[str, str]] = None, ca_certificate_path: Optional[str] = None, - server_telemetry_id: Optional[str] = None, disable_ssl_verification: bool = False, ): + if not gms_server: + raise ConfigurationError("gms server is required") self._gms_server = gms_server self._token = token self.server_config: Dict[str, Any] = {} - self.server_telemetry_id: str = "" self._session = requests.Session() diff --git a/metadata-ingestion/src/datahub_provider/hooks/datahub.py b/metadata-ingestion/src/datahub_provider/hooks/datahub.py index e8ae417ac3..e2e523fc5d 100644 --- a/metadata-ingestion/src/datahub_provider/hooks/datahub.py +++ b/metadata-ingestion/src/datahub_provider/hooks/datahub.py @@ -56,7 +56,7 @@ class DatahubRestHook(BaseHook): conn: "Connection" = self.get_connection(self.datahub_rest_conn_id) host = conn.host - if host is None: + if not host: raise AirflowException("host parameter is required") if conn.port: if ":" in host: