yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-01 19:25:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

converts links to use config object

Browse Source
This commit is contained in:
Seyi Adebajo 2018-08-26 23:25:51 -07:00
parent 2509b1ce77
commit a3b1ec4db4
12 changed files with 35 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
wherehows-web/app/components/dataset-aclaccess.ts
View File

@ -30,6 +30,12 @@ const minSelectableExpirationDate = new Date(Date.now() + millisecondDays());
const maxSelectableExpirationDate = new Date(Date.now() + millisecondDays(7));
export default class DatasetAclAccess extends Component {
/**
* Named component argument with a string link reference to more information on acls
* @type {string}
*/
aclMoreInfoLink: string;
/**
* The currently logged in user is listed on the related datasets acl
* @type {boolean}

9
wherehows-web/app/controllers/datasets/dataset.ts
View File

@ -66,6 +66,12 @@ export default class DatasetController extends Controller {
*/
jitAclAccessWhitelist: Array<DatasetPlatform>;
/**
* References the collection of help links with references to external pages of help information
* @type {Record<string, string>}
*/
wikiLinks: Record<string, string>;
/**
* Flag indicating the dataset policy is derived from an upstream source
* @type {boolean}
@ -140,8 +146,11 @@ export default class DatasetController extends Controller {
*/
constructor() {
super(...arguments);
// defaults
this.tabSelected || (this.tabSelected = Tabs.Ownership);
this.jitAclAccessWhitelist || (this.jitAclAccessWhitelist = []);
this.wikiLinks || (this.wikiLinks = {});
}
/**

3
wherehows-web/app/routes/datasets/dataset.ts
View File

@ -96,7 +96,8 @@ export default class DatasetRoute extends Route {
isInternal: !!getConfig('isInternal'),
jitAclAccessWhitelist: getConfig('JitAclAccessWhitelist') || [],
shouldShowDatasetLineage: getConfig('shouldShowDatasetLineage'),
shouldShowDatasetHealth: getConfig('shouldShowDatasetHealth')
shouldShowDatasetHealth: getConfig('shouldShowDatasetHealth'),
wikiLinks: getConfig('wikiLinks')
});
}

2
wherehows-web/app/templates/components/dataset-aclaccess.hbs
View File

@ -1,6 +1,6 @@
<div>
{{more-info
link="http://go/jitaclfaq"
link=@aclMoreInfoLink
tooltip="Click for more information on ACL Access"
}}
</div>

3
wherehows-web/app/templates/components/dataset-compliance.hbs
View File

@ -175,7 +175,7 @@
Compliance Purge Policy
{{more-info
link="http://go/gdpr/deletions/purgePolicies"
link=@wikiLinks.purgePolicies
tooltip="Click for more information Purge Policies"
}}
</p>
@ -212,6 +212,7 @@
{{#if (or isReadOnly isInitialEditStep)}}
{{datasets/schemaless-tagging
classificationHelpLink=@wikiLinks.dht
isEditable=(not isReadOnly)
classification=(readonly complianceInfo.confidentiality)
containsPersonalData=(readonly complianceInfo.containingPersonalData)

1
wherehows-web/app/templates/components/datasets/containers/dataset-acl-access.hbs
View File

@ -7,6 +7,7 @@
{{#if isJitAclAccessEnabled}}
{{dataset-aclaccess
acls=acls
aclMoreInfoLink=@aclMoreInfoLink
hasValidAclRequest=hasValidAclRequest
userAclRequest=userAclRequest
userHasAclAccess=userHasAclAccess

1
wherehows-web/app/templates/components/datasets/containers/dataset-compliance.hbs
View File

@ -24,6 +24,7 @@
datasetName=datasetName
schemaless=schemaless
platform=platform
wikiLinks=@wikiLinks
complianceInfo=complianceInfo
complianceSuggestion=complianceSuggestion
suggestionConfidenceThreshold=suggestionConfidenceThreshold

2
wherehows-web/app/templates/components/datasets/schemaless-tagging.hbs
View File

@ -30,7 +30,7 @@
Dataset security classification
{{more-info
link="http://go/dht"
link=@classificationHelpLink
tooltip="information dataset security classification"
}}
</h4>

2
wherehows-web/app/templates/datasets/dataset-compliance/-dataset-classification.hbs
View File

@ -7,7 +7,7 @@
{{more-info
link="http://go/gdpr-taxonomy#MetadataTaxonomyforDataSets-DatasetLevelTags"
link=@wikiLinks.gdprTaxonomy
tooltip="Click for more information on Dataset classification with examples"
}}
</p>

6
wherehows-web/app/templates/datasets/dataset-compliance/-dataset-compliance-entities.hbs
View File

@ -6,7 +6,7 @@
"IDs and PII in the schema"}}
{{more-info
link="http://go/gdpr-pii"
link=@wikiLinks.gdprPii
tooltip="Click for more information on Schema field format and types"
}}
@ -105,7 +105,7 @@
Field
{{more-info
link="http://go/tms-schema"
link=@wikiLinks.tmsSchema
tooltip="Click for more information on Schema"
}}
{{/head.column}}
@ -337,7 +337,7 @@
</div>
{{more-info
link="http://go/metadata-custom-regex"
link=@wikiLinks.metadataCustomRegex
tooltip="Click for more information on RegExp format"
}}

7
wherehows-web/app/templates/datasets/dataset.hbs
View File

@ -149,6 +149,7 @@
{{datasets/containers/dataset-compliance
urn=encodedUrn
platform=model.platform
wikiLinks=wikiLinks
datasetName=model.nativeName
notifyPiiStatus=(action "onNotifyPiiStatus")
setOnChangeSetChange=(action "setOnChangeSetChange")
@ -158,7 +159,11 @@
{{/tabs.tabpanel}}
{{#tabs.tabpanel tabIds.Access}}
{{datasets/containers/dataset-acl-access urn=encodedUrn isJitAclAccessEnabled=isJitAclAccessEnabled}}
{{datasets/containers/dataset-acl-access
urn=encodedUrn
aclMoreInfoLink=wikiLinks.jitAcl
isJitAclAccessEnabled=isJitAclAccessEnabled
}}
{{/tabs.tabpanel}}
{{#if shouldShowDatasetLineage}}

2
wherehows-web/app/typings/api/configurator/configurator.d.ts vendored
View File

@ -12,6 +12,8 @@ interface IAppConfig {
shouldShowDatasetHealth: boolean;
// confidence threshold for filtering out higher quality suggestions
suggestionConfidenceThreshold: number;
// collection of links to external help resource pages
wikiLinks: Record<string, string>;
tracking: {
isEnabled: boolean;
trackers: {