fix(cli): align default sink env variables across all cli commands (#4739)

metadata-ingestion/README.md

@@ -43,8 +43,8 @@ The default sink that most of the ingestion systems and guides assume is the `da
 A recipe is the main configuration file that puts it all together. It tells our ingestion scripts where to pull data from (source) and where to put it (sink).
 
 Since `acryl-datahub` version `>=0.8.33.2`, the default sink is assumed to be a DataHub REST endpoint:
-- Hosted at "http://localhost:8080" or the environment variable `${DATAHUB_HOST}` if present
-- With an empty auth token or the environment variable `${DATAHUB_TOKEN}` if present. 
+- Hosted at "http://localhost:8080" or the environment variable `${DATAHUB_GMS_HOST}` if present
+- With an empty auth token or the environment variable `${DATAHUB_GMS_TOKEN}` if present. 
 
 Here's a simple recipe that pulls metadata from MSSQL (source) and puts it into the default sink (datahub rest).
 
@@ -68,7 +68,7 @@ datahub ingest -c recipe.yaml
 
 or if you want to override the default endpoints, you can provide the environment variables as part of the command like below:
 ```shell
-DATAHUB_SERVER="https://my-datahub-server:8080" DATAHUB_TOKEN="my-datahub-token" datahub ingest -c recipe.yaml
+DATAHUB_GMS_HOST="https://my-datahub-server:8080" DATAHUB_GMS_TOKEN="my-datahub-token" datahub ingest -c recipe.yaml
 ```
 
 A number of recipes are included in the [examples/recipes](./examples/recipes) directory. For full info and context on each source and sink, see the pages described in the [table of plugins](../docs/cli.md#installing-plugins).

metadata-ingestion/src/datahub/ingestion/run/pipeline.py

@@ -71,8 +71,8 @@ class PipelineConfig(ConfigModel):
             default_sink_config = {
                 "type": "datahub-rest",
                 "config": {
-                    "server": "${DATAHUB_SERVER:-http://localhost:8080}",
-                    "token": "${DATAHUB_TOKEN:-}",
+                    "server": "${DATAHUB_GMS_HOST:-http://localhost:8080}",
+                    "token": "${DATAHUB_GMS_TOKEN:-}",
                 },
             }
             # resolve env variables if present