From a80d23e15a4d3d41c81aa89adc5e7333e178ea3f Mon Sep 17 00:00:00 2001 From: david-leifker <114954101+david-leifker@users.noreply.github.com> Date: Thu, 30 Jan 2025 08:18:38 -0600 Subject: [PATCH] fix(test): fix metadata-io test (#12503) --- .../request/SearchRequestHandlerTest.java | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/metadata-io/src/test/java/com/linkedin/metadata/search/query/request/SearchRequestHandlerTest.java b/metadata-io/src/test/java/com/linkedin/metadata/search/query/request/SearchRequestHandlerTest.java index d4d5b03ea5..62b9572d3c 100644 --- a/metadata-io/src/test/java/com/linkedin/metadata/search/query/request/SearchRequestHandlerTest.java +++ b/metadata-io/src/test/java/com/linkedin/metadata/search/query/request/SearchRequestHandlerTest.java @@ -195,13 +195,14 @@ public class SearchRequestHandlerTest extends AbstractTestNGSpringContextTests { // Filters Collection aggBuilders = sourceBuilder.aggregations().getAggregatorFactories(); - // Expect 3 aggregations: textFieldOverride, missing␝textFieldOverride, and _index - assertEquals(aggBuilders.size(), 3); + // Expect 3 aggregations: textFieldOverride, missing␝textFieldOverride, and _entityType, + // _entityType␝typeNames + assertEquals(aggBuilders.size(), 4); for (AggregationBuilder aggBuilder : aggBuilders) { - if (aggBuilder.getName().equals("textFieldOverride")) { + if (aggBuilder.getName().startsWith("textFieldOverride")) { TermsAggregationBuilder filterPanelBuilder = (TermsAggregationBuilder) aggBuilder; assertEquals(filterPanelBuilder.field(), "textFieldOverride.keyword"); - } else if (!aggBuilder.getName().equals("_entityType") + } else if (!aggBuilder.getName().startsWith("_entityType") && !aggBuilder .getName() .equals( @@ -241,13 +242,14 @@ public class SearchRequestHandlerTest extends AbstractTestNGSpringContextTests { // Filters Collection aggBuilders = sourceBuilder.aggregations().getAggregatorFactories(); - // Expect 2 aggregations: textFieldOverride and _index - assertEquals(aggBuilders.size(), 3); + // Expect 4 aggregations: textFieldOverride, missing:textFieldOverride, _entityType and + // _entityType:typeNames + assertEquals(aggBuilders.size(), 4); for (AggregationBuilder aggBuilder : aggBuilders) { - if (aggBuilder.getName().equals("textFieldOverride")) { + if (aggBuilder.getName().startsWith("textFieldOverride")) { TermsAggregationBuilder filterPanelBuilder = (TermsAggregationBuilder) aggBuilder; assertEquals(filterPanelBuilder.field(), "textFieldOverride.keyword"); - } else if (!aggBuilder.getName().equals("_entityType") + } else if (!aggBuilder.getName().startsWith("_entityType") && !aggBuilder .getName() .equals(