yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-29 19:46:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1058 from theseyi/emit-suggestion-feedback

Browse Source 
changes suggestion buttons to thumbs. annotates isRecentSuggestion re…
This commit is contained in:
Seyi Adebajo 2018-03-27 13:53:06 -04:00 committed by GitHub
commit a90a00a6c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
wherehows-web/app/constants/dataset-compliance.ts
View File

@ -180,7 +180,7 @@ const getIdTypeDataTypes = (complianceDataTypes: Array<IComplianceDataType> = []
const isRecentSuggestion = ( const isRecentSuggestion = (
policyModificationTime: IComplianceInfo['modifiedTime'], policyModificationTime: IComplianceInfo['modifiedTime'],
suggestionModificationTime: number suggestionModificationTime: number
) => ): boolean =>
// policy has not been modified previously or suggestion mod time is greater than or equal to interval // policy has not been modified previously or suggestion mod time is greater than or equal to interval
!policyModificationTime || !policyModificationTime ||
(!!suggestionModificationTime && (!!suggestionModificationTime &&

13
wherehows-web/app/templates/components/auto-suggest-action.hbs
View File

@ -1,15 +1,6 @@
{{#if (eq type "accept")}} {{#if (eq type "accept")}}
<svg viewBox="0 0 24 24" width="24px" height="24px" x="0" y="0" preserveAspectRatio="xMinYMin meet"> <i class="fa fa-thumbs-up fa-lg"></i>
<g class="large-icon" style="fill: currentColor">
<path d="M19.68,4L9,17.7,4.36,12,3,13.06l5.42,6.67A0.72,0.72,0,0,0,9,20a0.7,0.7,0,0,0,.59-0.28L21,5.05Z"></path>
</g>
</svg>
{{else}} {{else}}
<svg viewBox="0 0 24 24" width="24px" height="24px" x="0" y="0" preserveAspectRatio="xMinYMin meet"> <i class="fa fa-thumbs-down fa-lg"></i>
<g class="large-icon" style="fill: currentColor">
<path
d="M20,5.32L13.32,12,20,18.68,18.66,20,12,13.33,5.34,20,4,18.68,10.68,12,4,5.32,5.32,4,12,10.69,18.68,4Z"></path>
</g>
</svg>
{{/if}} {{/if}}