yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-26 01:18:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui/lineage): Do not hide transformational nodes in cycles with their parent (#14423)

Browse Source
This commit is contained in:
Andrew Sikowitz 2025-08-12 11:38:50 -07:00 committed by GitHub
parent 738f16ce91
commit b4842b194c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
datahub-web-react/src/app/lineageV2/useComputeGraph/getDisplayedNodes.ts
View File

@ -187,8 +187,10 @@ function getChildrenToFilter(
for (let node = queue.pop(); node; node = queue.pop()) {
const children = adjacencyList[direction].get(node.urn);
// Include non-query transformational nodes if they have no children
// Have to also include non-query transformational nodes in cycles with their parent, because
// those are effectively leaves as well.
if (
!children?.size &&
(!children?.size || (node.inCycle && children.has(parent.urn))) &&
!isQuery(node) &&
!(direction === LineageDirection.Downstream && isDbt(node) && node.entity?.subtype === SubType.DbtSource)
) {

4
datahub-web-react/src/app/lineageV3/useComputeGraph/getDisplayedNodes.ts
View File

@ -187,8 +187,10 @@ function getChildrenToFilter(
for (let node = queue.pop(); node; node = queue.pop()) {
const children = adjacencyList[direction].get(node.urn);
// Include non-query transformational nodes if they have no children
// Have to also include non-query transformational nodes in cycles with their parent, because
// those are effectively leaves as well.
if (
!children?.size &&
(!children?.size || (node.inCycle && children.has(parent.urn))) &&
!isQuery(node) &&
!(direction === LineageDirection.Downstream && isDbt(node) && node.entity?.subtype === SubType.DbtSource)
) {