refactor: use better assertj assertions. (#1975)

This commit is contained in:
John Plaisted 2020-10-29 11:46:25 -07:00 committed by GitHub
parent 0c92a8e887
commit b4d22fc463
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -52,9 +52,7 @@ public class DatasetIndexBuilderTest {
final List<DatasetDocument> actualDocs = _indexBuilder.getDocumentsToUpdate(datasetSnapshot);
// then
assertThat(actualDocs.size()).isEqualTo(2);
assertThat(actualDocs).contains(expectedDocument1);
assertThat(actualDocs).contains(expectedDocument2);
assertThat(actualDocs).containsExactly(expectedDocument1, expectedDocument2);
}
@Test
@ -75,9 +73,7 @@ public class DatasetIndexBuilderTest {
final List<DatasetDocument> actualDocs = new DatasetIndexBuilder().getDocumentsToUpdate(datasetSnapshot);
// then
assertThat(actualDocs.size()).isEqualTo(2);
assertThat(actualDocs).contains(expectedDocument1);
assertThat(actualDocs).contains(expectedDocument2);
assertThat(actualDocs).containsExactly(expectedDocument1, expectedDocument2);
}
@Test
@ -98,9 +94,7 @@ public class DatasetIndexBuilderTest {
final List<DatasetDocument> actualDocs = new DatasetIndexBuilder().getDocumentsToUpdate(datasetSnapshot);
// then
assertThat(actualDocs.size()).isEqualTo(2);
assertThat(actualDocs).contains(expectedDocument1);
assertThat(actualDocs).contains(expectedDocument2);
assertThat(actualDocs).containsExactly(expectedDocument1, expectedDocument2);
}
@Test
@ -121,9 +115,7 @@ public class DatasetIndexBuilderTest {
final List<DatasetDocument> actualDocs = new DatasetIndexBuilder().getDocumentsToUpdate(datasetSnapshot);
// then
assertThat(actualDocs.size()).isEqualTo(2);
assertThat(actualDocs).contains(expectedDocument1);
assertThat(actualDocs).contains(expectedDocument2);
assertThat(actualDocs).containsExactly(expectedDocument1, expectedDocument2);
}
@Test
@ -148,9 +140,7 @@ public class DatasetIndexBuilderTest {
final List<DatasetDocument> actualDocs = new DatasetIndexBuilder().getDocumentsToUpdate(datasetSnapshot);
// then
assertThat(actualDocs.size()).isEqualTo(2);
assertThat(actualDocs).contains(expectedDocument1);
assertThat(actualDocs).contains(expectedDocument2);
assertThat(actualDocs).containsExactly(expectedDocument1, expectedDocument2);
}
@Test
@ -182,9 +172,7 @@ public class DatasetIndexBuilderTest {
final List<DatasetDocument> actualDocs = new DatasetIndexBuilder().getDocumentsToUpdate(datasetSnapshot);
// then
assertThat(actualDocs.size()).isEqualTo(2);
assertThat(actualDocs).contains(expectedDocument1);
assertThat(actualDocs).contains(expectedDocument2);
assertThat(actualDocs).containsExactly(expectedDocument1, expectedDocument2);
}
@Test
@ -205,9 +193,7 @@ public class DatasetIndexBuilderTest {
final List<DatasetDocument> actualDocs = new DatasetIndexBuilder().getDocumentsToUpdate(datasetSnapshot);
// then
assertThat(actualDocs.size()).isEqualTo(2);
assertThat(actualDocs).contains(expectedDocument1);
assertThat(actualDocs).contains(expectedDocument2);
assertThat(actualDocs).containsExactly(expectedDocument1, expectedDocument2);
}
@Test
@ -229,9 +215,7 @@ public class DatasetIndexBuilderTest {
final List<DatasetDocument> actualDocs = new DatasetIndexBuilder().getDocumentsToUpdate(datasetSnapshot);
// then
assertThat(actualDocs.size()).isEqualTo(2);
assertThat(actualDocs).contains(expectedDocument1);
assertThat(actualDocs).contains(expectedDocument2);
assertThat(actualDocs).containsExactly(expectedDocument1, expectedDocument2);
}
@Test
@ -252,9 +236,7 @@ public class DatasetIndexBuilderTest {
final List<DatasetDocument> actualDocs = new DatasetIndexBuilder().getDocumentsToUpdate(datasetSnapshot);
// then
assertThat(actualDocs.size()).isEqualTo(2);
assertThat(actualDocs).contains(expectedDocument1);
assertThat(actualDocs).contains(expectedDocument2);
assertThat(actualDocs).containsExactly(expectedDocument1, expectedDocument2);
}
@Test
@ -280,8 +262,6 @@ public class DatasetIndexBuilderTest {
final List<DatasetDocument> actualDocs = new DatasetIndexBuilder().getDocumentsToUpdate(datasetSnapshot);
// then
assertThat(actualDocs.size()).isEqualTo(2);
assertThat(actualDocs).contains(expectedDocument1);
assertThat(actualDocs).contains(expectedDocument2);
assertThat(actualDocs).containsExactly(expectedDocument1, expectedDocument2);
}
}