yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-26 16:34:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(uplodaFiles): add feature flag (#14951)

Browse Source
This commit is contained in:
v-tarasevich-blitz-brain 2025-10-08 18:05:34 +03:00 committed by GitHub
parent d14ccdf57c
commit b7b4f1c9a5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java
View File

@ -266,6 +266,7 @@ public class AppConfigResolver implements DataFetcher<CompletableFuture<AppConfi
.setLogicalModelsEnabled(_featureFlags.isLogicalModelsEnabled())
.setShowHomepageUserRole(_featureFlags.isShowHomepageUserRole())
.setAssetSummaryPageV1(_featureFlags.isAssetSummaryPageV1())
.setDocumentationFileUploadV1(_featureFlags.isDocumentationFileUploadV1())
.build();
appConfig.setFeatureFlags(featureFlagsConfig);

5
datahub-graphql-core/src/main/resources/app.graphql
View File

@ -802,6 +802,11 @@ type FeatureFlagsConfig {
Enables displaying the asset summary page
"""
assetSummaryPageV1: Boolean!
"""
If enabled, allows uploading of files for documentation.
"""
documentationFileUploadV1: Boolean!
}
"""

1
datahub-graphql-core/src/test/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolverTest.java
View File

@ -132,6 +132,7 @@ public class AppConfigResolverTest {
when(mockFeatureFlags.isLogicalModelsEnabled()).thenReturn(false);
when(mockFeatureFlags.isShowHomepageUserRole()).thenReturn(false);
when(mockFeatureFlags.isAssetSummaryPageV1()).thenReturn(false);
when(mockFeatureFlags.isDocumentationFileUploadV1()).thenReturn(false);
}
@Test

1
datahub-web-react/src/appConfigContext.tsx
View File

@ -91,6 +91,7 @@ export const DEFAULT_APP_CONFIG = {
logicalModelsEnabled: false,
showHomepageUserRole: false,
assetSummaryPageV1: false,
documentationFileUploadV1: false,
},
chromeExtensionConfig: {
enabled: false,

1
datahub-web-react/src/graphql/app.graphql
View File

@ -113,6 +113,7 @@ query appConfig {
logicalModelsEnabled
showHomepageUserRole
assetSummaryPageV1
documentationFileUploadV1
}
chromeExtensionConfig {
enabled

1
metadata-io/src/test/java/com/linkedin/metadata/system_info/collectors/PropertiesCollectorConfigurationTest.java
View File

@ -464,6 +464,7 @@ public class PropertiesCollectorConfigurationTest extends AbstractTestNGSpringCo
"featureFlags.businessAttributeEntityEnabled",
"featureFlags.cdcModeChangeLog",
"featureFlags.dataContractsEnabled",
"featureFlags.documentationFileUploadV1",
"featureFlags.editableDatasetNameEnabled",
"featureFlags.entityVersioning",
"featureFlags.erModelRelationshipFeatureEnabled",

1
metadata-service/configuration/src/main/java/com/linkedin/datahub/graphql/featureflags/FeatureFlags.java
View File

@ -50,4 +50,5 @@ public class FeatureFlags {
private boolean showHomepageUserRole = false;
private boolean assetSummaryPageV1 = false;
private boolean showDefaultExternalLinks = true;
private boolean documentationFileUploadV1 = false;
}

1
metadata-service/configuration/src/main/resources/application.yaml
View File

@ -842,6 +842,7 @@ featureFlags:
fineGrainedLineageNotAllowedForPlatforms: ${FINE_GRAINED_LINEAGE_NOT_ALLOWED_FOR_PLATFORMS:} # Comma separated list of platforms for which schemaFields entity edges will not be allowed to be created. for example: "hdfs, s3"
assetSummaryPageV1: ${ASSET_SUMMARY_PAGE_V1:false} # Enables displaying the asset summary page
showDefaultExternalLinks: ${SHOW_DEFAULT_EXTERNAL_LINKS:true} # If turned on, show the default external links on the entity page
documentationFileUploadV1: ${DOCUMENTATION_FILE_UPLOAD_V1:false} # Enables uploading of files for documentation
entityChangeEvents:
enabled: ${ENABLE_ENTITY_CHANGE_EVENTS_HOOK:true}