Minor modification on v2 API (#973)

This commit is contained in:
Yi (Alan) Wang 2018-02-20 11:56:37 -08:00 committed by GitHub
parent 6fe1f268cf
commit b81e3e82da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 13 additions and 9 deletions

View File

@ -57,7 +57,7 @@ public class DatasetComplianceDao extends BaseDao {
return dsComplianceToDatasetCompliance(findComplianceById(datasetId));
}
@Nullable
@Nonnull
public DatasetCompliance getDatasetComplianceByUrn(@Nonnull String datasetUrn) throws Exception {
throw new UnsupportedOperationException("Not implemented yet, use getDatasetComplianceByDatasetId");
}

View File

@ -82,12 +82,11 @@ public class FieldDetailDao extends BaseDao {
/**
* Insert or update Schemaless from MetadataChangeEvent
* @param identifier DatasetIdentifier
* @param dataset DictDataset
* @param auditStamp ChangeAuditStamp
* @throws Exception
*/
public void insertUpdateSchemaless(@Nonnull DatasetIdentifier identifier, @Nullable DictDataset dataset,
@Nonnull ChangeAuditStamp auditStamp) throws Exception {
public void insertUpdateSchemaless(@Nonnull DatasetIdentifier identifier, @Nonnull ChangeAuditStamp auditStamp)
throws Exception {
throw new UnsupportedOperationException("Support for Schemaless not yet implemented.");
}

View File

@ -101,15 +101,18 @@ public class DatasetViewDao extends BaseViewDao {
return view;
}
@Nonnull
public PagedCollection<DatasetView> listDatasets(@Nullable String platform, @Nullable String origin,
@Nonnull String prefix, int start, int count) throws Exception {
throw new UnsupportedOperationException("Not implemented yet");
}
@Nonnull
public List<String> listSegments(@Nonnull String platform, @Nullable String origin, @Nonnull String prefix) throws Exception {
throw new UnsupportedOperationException("Not implemented yet");
}
@Nonnull
public List<String> listFullNames(@Nonnull String platform, @Nullable String origin, @Nonnull String prefix) throws Exception {
throw new UnsupportedOperationException("Not implemented yet");
}

View File

@ -42,4 +42,6 @@ public class DatasetCompliance {
private String modifiedBy;
private Long modifiedTime;
private Boolean fromUpstream;
}

View File

@ -266,6 +266,10 @@ GET /api/v1/jira/tickets/:managerId
POST /api/v1/tracking controllers.api.v1.Tracking.addTrackingEvent()
GET /api/v2/list/platforms controllers.api.v2.Dataset.getDataPlatforms
GET /api/v2/list/complianceDataTypes controllers.api.v2.Dataset.getComplianceDataTypes
GET /api/v2/platforms/:platform/prefix/:prefix controllers.api.v2.Dataset.listSegments(platform: String, prefix: String)
GET /api/v2/platforms/:platform controllers.api.v2.Dataset.listSegments(platform: String, prefix = "")
@ -284,10 +288,6 @@ GET /api/v2/datasets/count/platform/:platform
GET /api/v2/datasets/count controllers.api.v2.Dataset.countDatasets(platform = null, prefix = "")
GET /api/v2/list/platforms controllers.api.v2.Dataset.getDataPlatforms
GET /api/v2/list/complianceDataTypes controllers.api.v2.Dataset.getComplianceDataTypes
GET /api/v2/datasets/:urn controllers.api.v2.Dataset.getDataset(urn: String)
PUT /api/v2/datasets/:urn/deprecate controllers.api.v2.Dataset.updateDatasetDeprecation(urn: String)

View File

@ -125,7 +125,7 @@ public class MetadataChangeProcessor extends KafkaMessageProcessor {
if (dsSchema != null) { // if instanceof DatasetSchema
_fieldDetailDao.insertUpdateDatasetFields(identifier, dataset, event.datasetProperty, changeAuditStamp, dsSchema);
} else if (event.schema instanceof Schemaless) { // if instanceof Schemaless
_fieldDetailDao.insertUpdateSchemaless(identifier, dataset, changeAuditStamp);
_fieldDetailDao.insertUpdateSchemaless(identifier, changeAuditStamp);
}
// if owners are not null, insert or update owner