yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-26 17:37:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Create Tag Modal Issue: Clear the input value on press. (#6212)

Browse Source
This commit is contained in:
Ankit keshari 2022-10-20 20:52:37 +05:30 committed by GitHub
parent 333598fda2
commit bd217f8a58
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
datahub-web-react/src/app/shared/constants.ts Normal file
View File

@ -0,0 +1 @@
export const ENTER_KEY_CODE = 13;

15
datahub-web-react/src/app/shared/tags/AddTagsTermsModal.tsx
View File

@ -18,6 +18,7 @@ import { useEntityRegistry } from '../../useEntityRegistry';
import { useGetRecommendations } from '../recommendation';
import { FORBIDDEN_URN_CHARS_REGEX } from '../../entity/shared/utils';
import { TagTermLabel } from './TagTermLabel';
import { ENTER_KEY_CODE } from '../constants';
export enum OperationType {
ADD,
@ -192,12 +193,17 @@ export default function EditTagTermsModal({
querySelectorToExecuteClick: '#addTagButton',
});
function handleOnClickBack() {
setInputValue('');
setShowCreateModal(false);
}
if (showCreateModal) {
return (
<CreateTagModal
visible={visible}
onClose={onCloseModal}
onBack={() => setShowCreateModal(false)}
onBack={handleOnClickBack}
tagName={inputValue}
resources={resources}
/>
@ -406,6 +412,12 @@ export default function EditTagTermsModal({
setInputValue('');
}
function handleKeyDown(event) {
if (event.keyCode === ENTER_KEY_CODE) {
(inputEl.current as any).blur();
}
}
const isShowingGlossaryBrowser = !inputValue && type === EntityType.GlossaryTerm && isFocusedOnInput;
return (
@ -453,6 +465,7 @@ export default function EditTagTermsModal({
onClear={clearInput}
onFocus={() => setIsFocusedOnInput(true)}
onBlur={handleBlur}
onInputKeyDown={handleKeyDown}
dropdownStyle={isShowingGlossaryBrowser ? { display: 'none' } : {}}
>
{tagSearchOptions}